Skip to content

Issue1473 pvt validation ext#1481

Open
LoneMeertens wants to merge 87 commits into
masterfrom
issue1473_PvtValidationExt
Open

Issue1473 pvt validation ext#1481
LoneMeertens wants to merge 87 commits into
masterfrom
issue1473_PvtValidationExt

Conversation

@LoneMeertens
Copy link
Copy Markdown
Contributor

Summary

This PR upgrades the PVT validation framework to use EN ISO 9806:2017 quasi-dynamic parameters as the canonical input for the developed PVT model.

To ensure compatibility with other datasheet standards, an Excel conversion template is included in
IDEAS.Resources.Data.Fluid.PVTCollectors that converts coefficients from:

  • EN ISO 9806:2013 (Unglazed steady-state and Quasi-dynamic)
  • EN ISO 9806:2025 Quasi-dynamic

to the ISO 9806:2017 parameter set.

Reference

Conversion methodology and model upgrades and model validation are described in:
Meertens, L.; Jansen, J.; Helsen, L. (2026).
Development and Experimental Validation of an Open-Source Unglazed Photovoltaic-Thermal Collector Modelica Model that only needs Datasheet Parameters.
Submitted to Mathematical and Computer Modelling of Dynamical Systems.

Related issue: #1473

… wind speed to reduced wind speed as required by ISO9806:2017
… 2017 standard supports broader range of collectors
@LoneMeertens
Copy link
Copy Markdown
Contributor Author

@jelgerjansen,

Thank you for addressing these useful comments and suggestions.
The main updates included in this PR are:

  • Added partialPVTCollectorValidation, which now serves as the common base for both PVT_UI and PVT_UN collectors.
  • Generalized the ElectricalPV model and moved it to Validation.BaseClasses so it can be used consistently by both PVT_UI and PVT_UN models.
  • Refactored the Validation models PVT_UN_* so that they now extend from the corresponding PVT_UI_*_DayType1 models, thereby removing duplicated code.
  • Moved documentation to the top‑level package and now reference it from the corresponding sub‑packages to avoid duplication and simplify long‑term maintenance.
  • Updated documentation based on the latest paper.
  • Updated revision history so that each model now only includes revisions relevant to itself.
  • Renamed parameters to follow naming conventions consistently.
  • Cleaned up the code structure throughout.

The only suggestion I have not (yet) included is:

IDEAS.Fluid.PVTCollectors.PVTCollector using the Excel file located at IDEAS.Resources.Data.Fluid.PVTCollectors. — Easier for users if a Python script is written?

I specifically opted to keep the Excel file because it provides the most low‑barrier and fastest way for users to derive the required coefficients. However, I do have a Jupyter Notebook version available if this would be more convenient. I would be happy to include it if preferred.

I still need to rerun the unit tests later this week.
After that, we should be ready to close this PR.

Thanks again for the detailed review!

@LoneMeertens
Copy link
Copy Markdown
Contributor Author

@jelgerjansen, any progress on this review? All previous suggestions have been taken into account, and the reference results for the full PVTCollectors package have also been updated.

Should I assign a second reviewer as well before this can be merged?

Copy link
Copy Markdown
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LoneMeertens thanks for addressing the comments. I've done a final review from my side. Please also check the line breaks of the documentation parts: ideally, these are a bit more readible in code view than they are right now.

After this, I would do another internal review by another SySi. After that, it can be merged in IBPSA, where it will also be reviewed by at least one non-KUL member.

Comment thread IDEAS/Fluid/PVTCollectors/BaseClasses/Examples/ISO9806HeatLoss.mo
Comment thread IDEAS/Fluid/PVTCollectors/BaseClasses/ElectricalPVT.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/BaseClasses/ElectricalPVT.mo
Comment thread IDEAS/Fluid/PVTCollectors/Validation/BaseClasses/ElectricalPV.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/Validation/BaseClasses/ElectricalPV.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/Validation/PVT_UI/PVTCollectorValidation.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_Electrical.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/PVTCollectorValidation.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/PVTCollectorValidation.mo Outdated
Comment thread IDEAS/Fluid/PVTCollectors/Validation/package.mo
@LoneMeertens
Copy link
Copy Markdown
Contributor Author

Thank you @jelgerjansen for all the work you put into this PR, really appreciated!
I’ve taken into account all your requested changes.

@lucasverleyen, would you have some time and interest to go over this PR as a second internal SySi reviewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants