Issue1473 pvt validation ext#1481
Conversation
…nd c6 are set to 0
…2013 to ISO 9806 2017
…pplicable beyond quasi dynamic approach
…tandard is generic
… wind speed to reduced wind speed as required by ISO9806:2017
… 2017 standard supports broader range of collectors
…ve quasi-dynamic namings)
…P section of datasheet
|
Thank you for addressing these useful comments and suggestions.
The only suggestion I have not (yet) included is:
I specifically opted to keep the Excel file because it provides the most low‑barrier and fastest way for users to derive the required coefficients. However, I do have a Jupyter Notebook version available if this would be more convenient. I would be happy to include it if preferred. I still need to rerun the unit tests later this week. Thanks again for the detailed review! |
|
@jelgerjansen, any progress on this review? All previous suggestions have been taken into account, and the reference results for the full Should I assign a second reviewer as well before this can be merged? |
jelgerjansen
left a comment
There was a problem hiding this comment.
@LoneMeertens thanks for addressing the comments. I've done a final review from my side. Please also check the line breaks of the documentation parts: ideally, these are a bit more readible in code view than they are right now.
After this, I would do another internal review by another SySi. After that, it can be merged in IBPSA, where it will also be reviewed by at least one non-KUL member.
|
Thank you @jelgerjansen for all the work you put into this PR, really appreciated! @lucasverleyen, would you have some time and interest to go over this PR as a second internal SySi reviewer? |
Summary
This PR upgrades the PVT validation framework to use EN ISO 9806:2017 quasi-dynamic parameters as the canonical input for the developed PVT model.
To ensure compatibility with other datasheet standards, an Excel conversion template is included in
IDEAS.Resources.Data.Fluid.PVTCollectorsthat converts coefficients from:to the ISO 9806:2017 parameter set.
Reference
Conversion methodology and model upgrades and model validation are described in:
Meertens, L.; Jansen, J.; Helsen, L. (2026).
Development and Experimental Validation of an Open-Source Unglazed Photovoltaic-Thermal Collector Modelica Model that only needs Datasheet Parameters.
Submitted to Mathematical and Computer Modelling of Dynamical Systems.
Related issue: #1473