Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to configure the multiple lpars-v2 #796

Closed
wants to merge 3 commits into from

Conversation

SamirMulani
Copy link
Contributor

This enhancement introduces support for configuring multiple lpars, such as lpar1, lpar2, and so on, especially when they are in shared mode.

To configure the multiple lpars user need to pass below two parameters, lpar_config=multi
lpar_lis=lpar1, lpar2 ...etc
In this case, users are required to explicitly specify these two parameters in the .conf file, and it's important to ensure that all lpars have unique passwords.

This enhancement introduces support for configuring multiple lpars,
such as lpar1, lpar2, and so on, especially when they are in shared mode.

To configure the multiple lpars user need to pass below two parameters,
lpar_config=multi
lpar_lis=lpar1, lpar2 ...etc
In this case, users are required to explicitly specify these two parameters
in the .conf file, and it's important to ensure that all lpars have unique
passwords.

Signed-off-by: Samir Mulani <[email protected]>
Copy link
Contributor

@sacsant sacsant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes seem to be unrelated to multi LPAR configuration. Can you split this into 2 commits -- one for formatting related changes and another for multi par config support, so that its easier to review

root and others added 2 commits November 29, 2023 01:48
To fix the indetation error i have run the below command,
->autopep8 -i MachineConfig.py

Signed-off-by: Samir Mulani <[email protected]>
This enhancement introduces support for configuring multiple lpars,
such as lpar1, lpar2, and so on, especially when they are in shared mode.

To configure the multiple lpars user need to pass below two parameters,
lpar_config=multi
lpar_lis=lpar1, lpar2 ...etc
In this case, users are required to explicitly specify these two parameters
in the .conf file, and it's important to ensure that all lpars have unique
passwords.

Signed-off-by: Samir Mulani <[email protected]>
@SamirMulani
Copy link
Contributor Author

Addressed the above review comments in the below pull request, so closing current PR.
#798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants