fix(screenshots): render light and dark in collapsible per-page sections#448
Merged
vitorvasc merged 4 commits intoMay 11, 2026
Merged
Conversation
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
✅ Deploy Preview for otel-ecosystem-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PR screenshots comment formatting produced by GitHub Actions, aiming to show light/dark variants and to group screenshots into collapsible per-page sections.
Changes:
- Changes the comment image URL pattern to
{viewport}-{theme}-{slug}.pngand renders Light/Dark tables per page inside<details>sections. - Disables the screenshots cleanup workflow job via
if: falseto preserve older PR screenshot links.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/screenshots-commit.yml | Adjusts PR comment body generation to use per-page <details> sections and separate Light/Dark screenshot tables with theme-specific filenames. |
| .github/workflows/screenshots-cleanup.yml | Disables the cleanup job to avoid deleting PR screenshot folders on the otelbot/screenshots branch. |
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
vitorvasc
force-pushed
the
fix/screenshots-workflow-dual-theme
branch
from
c1fa9b4 to
f7afdd1
Compare
jaydeluca
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{viewport}-{theme}-{slug}.png.<details>block per page.screenshots-cleanup.ymlis gated byif: false. Closed and merged PRs keep their screenshot folder onotelbot/screenshots, so image links in older PR comments stay alive. Flip the gate to re-enable deletion if needed.