Skip to content

fix(screenshots): render light and dark in collapsible per-page sections #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitorvasc merged 4 commits into from
May 11, 2026
Merged

fix(screenshots): render light and dark in collapsible per-page sections #448

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7903cb5
fix(screenshots): render light and dark in collapsible per-page sections
vitorvasc May 11, 2026
1491ae5
Merge branch 'main' into fix/screenshots-workflow-dual-theme
vitorvasc May 11, 2026
d9f822a
feat(screenshots): capture both light and dark themes
vitorvasc May 11, 2026
f7afdd1
chore(docs): update screenshots workflow docs
vitorvasc May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/screenshots-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ concurrency:

jobs:
cleanup:
# Disabled to avoid breaking images on older PRs. Flip to `true` to re-enable deletion.
if: false
runs-on: ubuntu-latest
Comment thread
vitorvasc marked this conversation as resolved.
steps:
- name: Get otelbot token
Expand Down
25 changes: 18 additions & 7 deletions .github/workflows/screenshots-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,26 @@ jobs:
base_url = f"https://raw.githubusercontent.com/{repo}/otelbot/screenshots/{pr_number}"
timestamp = datetime.now(timezone.utc).strftime("%Y-%m-%d %H:%M UTC")

def table(slug):
VIEWPORTS = ("desktop", "tablet", "mobile")

def theme_table(slug, theme):
cells = " | ".join(
f"![{slug} {vp} {theme}]({base_url}/{vp}-{theme}-{slug}.png)"
for vp in VIEWPORTS
)
Comment thread
vitorvasc marked this conversation as resolved.
Comment thread
vitorvasc marked this conversation as resolved.
Comment thread
vitorvasc marked this conversation as resolved.
return (
"| Desktop | Tablet | Mobile |\n"
"|---|---|---|\n"
f"| ![{slug} desktop]({base_url}/desktop-{slug}.png)"
f" | ![{slug} tablet]({base_url}/tablet-{slug}.png)"
f" | ![{slug} mobile]({base_url}/mobile-{slug}.png) |"
f"| {cells} |"
)

def page_section(label, slug):
return (
f"<details>\n"
f"<summary><strong>{label}</strong></summary>\n\n"
f"**Light**\n\n{theme_table(slug, 'light')}\n\n"
f"**Dark**\n\n{theme_table(slug, 'dark')}\n\n"
f"</details>"
Comment thread
vitorvasc marked this conversation as resolved.
)

pages = [
Expand All @@ -140,9 +153,7 @@ jobs:
("Collector Detail", "collector-detail"),
]

sections = "\n\n".join(
f"**{label}**\n\n{table(slug)}" for label, slug in pages
)
sections = "\n\n".join(page_section(label, slug) for label, slug in pages)

footer = (
f"_Captured from [`{short_sha}`]({commit_url}) on `{head_ref}` "
Expand Down
Loading