-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add opentelemetry-instrumentation-aiokafka #2082
Conversation
0679866
to
bf109ce
Compare
Test fixed, entry added to changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
instrumentation/opentelemetry-instrumentation-aiokafka/README.rst
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-aiokafka/README.rst
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-aiokafka/README.rst
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-aiokafka/pyproject.toml
Outdated
Show resolved
Hide resolved
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-aiokafka/tests/test_instrumentation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Riccardo Magliocchetti <[email protected]>
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Show resolved
Hide resolved
...pentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/__init__.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-aiokafka/README.rst
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-aiokafka/pyproject.toml
Outdated
Show resolved
Hide resolved
...n/opentelemetry-instrumentation-aiokafka/src/opentelemetry/instrumentation/aiokafka/utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
instrumentation/opentelemetry-instrumentation-aiokafka/README.rst
Outdated
Show resolved
Hide resolved
Note: This week I would like to add more tests, can you wait for me before you merge PR? |
I think we can add new tests in a follow-up PR. We want to merge this to avoid namespace squatting issues. |
Description
This PR adds an instrumentator for aiokafka, based on
opentelemetry-python-kafka-python
. #1957 seems stale.See also open-telemetry/opentelemetry-python#2645.
Type of change
Please delete options that are not relevant.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.