Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add opentelemetry-instrumentation-aiokafka #2082

Merged
merged 21 commits into from
Sep 16, 2024

Conversation

dimastbk
Copy link
Contributor

@dimastbk dimastbk commented Dec 6, 2023

Description

This PR adds an instrumentator for aiokafka, based on opentelemetry-python-kafka-python. #1957 seems stale.

See also open-telemetry/opentelemetry-python#2645.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@dimastbk dimastbk requested a review from a team December 6, 2023 17:12
Copy link

linux-foundation-easycla bot commented Dec 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@dimastbk
Copy link
Contributor Author

Test fixed, entry added to changelog

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@dimastbk dimastbk requested a review from xrmx September 1, 2024 16:23
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dimastbk
Copy link
Contributor Author

dimastbk commented Sep 16, 2024

Note: This week I would like to add more tests, can you wait for me before you merge PR?

@emdneto
Copy link
Member

emdneto commented Sep 16, 2024

Note: This week I would like to add more tests, can you wait for me before you mergePR?

I think we can add new tests in a follow-up PR. We want to merge this to avoid namespace squatting issues.

@lzchen lzchen merged commit 1a39ac8 into open-telemetry:main Sep 16, 2024
528 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants