httpx: fix handling of async hooks #2823
Merged
+63
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't default to sync hooks for async hooks, then check that they are actually async. Fixes open-telemetry#2734
xrmx
force-pushed
the
fix-http-async-hooks
branch
from
0e700b7
to
e4b0ea4
Compare
emdneto
reviewed
Aug 26, 2024
emdneto
reviewed
Aug 26, 2024
instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py
Show resolved
Hide resolved
Co-authored-by: Emídio Neto <[email protected]>
emdneto
approved these changes
Aug 26, 2024
lzchen
approved these changes
Aug 26, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't default to sync hooks for async hooks, then check that they are actually async. Needed to fix current tests that were testing only the sync path because tests are inherited from a base class 💔 .
Fixes #2734
Supersedes #2794
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.