feat: loan-module library by Nagarjuna0033 · Pull Request #2055 · openMF/mifos-pay

Nagarjuna0033 · 2026-07-19T18:10:45Z

Issue Fix

Jira Task: [365]

Screen_recording_20260719_233848.webm

Screen_recording_20260722_231727.webm

coderabbitai · 2026-07-19T18:10:58Z

Important

Review skipped

Too many files!

This PR contains 147 files, which is 47 over the limit of 100.

To get a review, narrow the scope:
• coderabbit review --committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cc73576-19b9-47fb-bdff-1e7d6673771f

📥 Commits

Reviewing files that changed from the base of the PR and between bbe0ea9 and 44de1ea.

📒 Files selected for processing (147)

cmp-android/dependencies/prodReleaseRuntimeClasspath.tree.txt
cmp-android/dependencies/prodReleaseRuntimeClasspath.txt
cmp-shared/build.gradle.kts
cmp-shared/src/commonMain/kotlin/org/mifospay/shared/di/KoinModules.kt
cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt
docs/LOAN_APPLICATION_ARCHITECTURE.md
feature/accounts/src/commonMain/composeResources/values-es/strings.xml
feature/accounts/src/commonMain/composeResources/values/strings.xml
feature/accounts/src/commonMain/kotlin/org/mifospay/feature/accounts/AccountViewModel.kt
feature/accounts/src/commonMain/kotlin/org/mifospay/feature/accounts/AccountsScreen.kt
gradle/libs.versions.toml
libs/mifos-loans/build.gradle.kts
libs/mifos-loans/src/androidMain/kotlin/org/mifos/lib/loan/ui/providerWebView/PlatformWebView.android.kt
libs/mifos-loans/src/commonMain/composeResources/values-ar/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-bn/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-es/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-fa/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-fr/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-hi/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-in/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-km/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-kn/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-ml/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-my/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-pl/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-pt/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-ru/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-sw/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-te/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values-ur/strings.xml
libs/mifos-loans/src/commonMain/composeResources/values/strings.xml
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/component/ApplyLoanBottomBar.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/component/ConfirmDetailsCard.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/component/DocumentType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/component/LoanCard.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/component/SignatureUploadType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/component/TermsAndConditionItem.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/component/UploadDocsSection.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/LoanProvider.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/AccountLinkingOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/AccountingRule.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/AllowAttributeOverrides.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/AmortizationType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/AmortizationTypeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/CalendarData.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/ChargeAppliesTo.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/ChargeCalculationType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/ChargeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/ChargePaymentMode.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/ChargeTimeType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/Currency.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/DaysInMonthType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/DaysInYearType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/EntityType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/EventType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/Frequency.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/FundOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/InterestCalculationPeriodType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/InterestRateFrequencyType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/InterestRateFrequencyTypeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/InterestRecalculationCompoundingType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/InterestRecalculationData.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/InterestType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/InterestTypeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/LoanCollateralOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/LoanOfficerOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/LoanPurposeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/LoanState.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/LoanTemplate.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/LoansPayload.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/Product.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/ProductOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RecalculationCompoundingFrequencyType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RecalculationRestFrequencyType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RepaymentFrequencyDaysOfWeekTypeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RepaymentFrequencyNthDayTypeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RepaymentFrequencyType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RepaymentFrequencyTypeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RepeatsOnNthDayOfMonth.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/RescheduleStrategyType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/StatusNavigationDestination.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/TaxGroup.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/TermFrequencyTypeOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/TermPeriodFrequencyType.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/Timeline.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/TransactionProcessingStrategyOptions.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/core/model/Type.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/di/LoanApplicationModule.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/mapper/ChargeMapper.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/mapper/CurrencyMapper.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/mapper/InterestRecalculationMapper.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/mapper/LoanAccountApplicationMapper.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/mapper/LoanTemplateMapper.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/mapper/LoanTypeMapper.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/navigation/LoanApplicationNavGraph.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/ApiEndPoints.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/LoansService.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/di/LoansNetworkModule.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/AccountLinkingOptionsResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/AllowAttributesOverridesResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/CalendarDataResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/ChargeOptionsResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/CurrencyResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/FundOptionsResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/InterestRecalculationDataResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanAccountApplicationPayloadDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanCollateralOptionsResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanOfficerOptionsResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanProductOptionsResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanProductResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanPurposeOptionsResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanTemplateResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/LoanTimelineResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/network/model/TypeResponseDto.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/providers/DummyLoanProvider.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/providers/FineractLoanProvider.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/providers/LoanProviderRegistry.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/repository/LoansRepository.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/repository/LoansRepositoryImpl.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/confirmDetails/ConfirmDetailsRoute.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/confirmDetails/ConfirmDetailsScreen.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/confirmDetails/ConfirmDetailsViewModel.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/loanApply/LoanApplyRoute.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/loanApply/LoanApplyScreen.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/loanApply/LoanApplyViewModel.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/loanProductDetails/LoanProductDetailsRoute.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/loanProductDetails/LoanProductDetailsScreen.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/loanProductDetails/LoanProductDetailsViewModel.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/providerWebView/LoanProviderUrls.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/providerWebView/LoanProviderWebViewRoute.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/providerWebView/LoanProviderWebViewScreen.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/providerWebView/LoanProviderWebViewViewModel.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/providerWebView/PlatformWebView.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/selectLoanProvider/SelectLoanProviderRoute.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/selectLoanProvider/SelectLoanProviderScreen.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/selectLoanProvider/SelectLoanProviderViewModel.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/selectLoanType/SelectLoanTypeRoute.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/selectLoanType/SelectLoanTypeScreen.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/selectLoanType/SelectLoanTypeViewModel.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/uploadDocs/UploadDocsRoute.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/uploadDocs/UploadDocsScreen.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/uploadDocs/UploadDocsViewModel.kt
libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/ui/uploadDocs/component/BottomSheetContent.kt
libs/mifos-loans/src/desktopMain/kotlin/org/mifos/lib/loan/ui/providerWebView/PlatformWebView.desktop.kt
libs/mifos-loans/src/jsMain/kotlin/org/mifos/lib/loan/ui/providerWebView/PlatformWebView.js.kt
libs/mifos-loans/src/nativeMain/kotlin/org/mifos/lib/loan/ui/providerWebView/PlatformWebView.native.kt
libs/mifos-loans/src/wasmJsMain/kotlin/org/mifos/lib/loan/ui/providerWebView/PlatformWebView.wasmJs.kt

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

Review on demand using usage pricing

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

revanthkumarJ

Let me know once you resolve conflicts

# Conflicts: # cmp-android/dependencies/prodReleaseRuntimeClasspath.tree.txt # cmp-android/dependencies/prodReleaseRuntimeClasspath.txt # cmp-shared/build.gradle.kts # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/di/KoinModules.kt

revanthkumarJ

fix static checks of desktop and let me know i will merge this one

feat: loan-module library

4964d69

Nagarjuna0033 requested a review from a team July 19, 2026 18:10

fix: checks

d1ff078

revanthkumarJ previously approved these changes Jul 21, 2026

View reviewed changes

feat: webview for providers

f078081

Nagarjuna0033 dismissed revanthkumarJ’s stale review via f078081 July 22, 2026 17:47

Nagarjuna0033 added 2 commits July 22, 2026 23:24

Merge branch 'dev' into feat/loan-module

0ad2301

# Conflicts: # cmp-android/dependencies/prodReleaseRuntimeClasspath.tree.txt # cmp-android/dependencies/prodReleaseRuntimeClasspath.txt # cmp-shared/build.gradle.kts # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/di/KoinModules.kt

Merge branch 'dev' into feat/loan-module

44de1ea

# Conflicts: # cmp-android/dependencies/prodReleaseRuntimeClasspath.tree.txt # cmp-android/dependencies/prodReleaseRuntimeClasspath.txt # cmp-shared/build.gradle.kts # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/di/KoinModules.kt

revanthkumarJ requested changes Jul 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: loan-module library#2055

feat: loan-module library#2055
Nagarjuna0033 wants to merge 5 commits into
openMF:devfrom
Nagarjuna0033:feat/loan-module

Nagarjuna0033 commented Jul 19, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 19, 2026 •

edited

Loading

Review skipped

Uh oh!

revanthkumarJ left a comment

Uh oh!

revanthkumarJ left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Nagarjuna0033 commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Fix

Uh oh!

coderabbitai Bot commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

revanthkumarJ left a comment

Choose a reason for hiding this comment

Uh oh!

revanthkumarJ left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Nagarjuna0033 commented Jul 19, 2026 •

edited

Loading

coderabbitai Bot commented Jul 19, 2026 •

edited

Loading