feat: loan-module library

cmp-android/dependencies/prodReleaseRuntimeClasspath.tree.txt

@@ -3466,6 +3466,70 @@
 |    |    +--- org.jetbrains.compose.components:components-resources:1.9.3 -> 1.10.0 (*)
 |    |    +--- org.jetbrains.compose.components:components-ui-tooling-preview:1.9.3 (*)
 |    |    \--- project :core:common (*)
+|    +--- project :libs:mifos-loans
+|    |    +--- androidx.lifecycle:lifecycle-runtime-compose:2.9.4 (*)
+|    |    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.9.4 (*)
+|    |    +--- androidx.tracing:tracing-ktx:1.3.0 (*)
+|    |    +--- io.insert-koin:koin-bom:4.1.1 (*)
+|    |    +--- io.insert-koin:koin-android:4.1.1 (*)
+|    |    +--- io.insert-koin:koin-androidx-compose:4.1.1 (*)
+|    |    +--- io.insert-koin:koin-androidx-navigation:4.1.1 (*)
+|    |    +--- io.insert-koin:koin-core-viewmodel:4.1.1 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 (*)
+|    |    +--- io.insert-koin:koin-core:4.1.1 (*)
+|    |    +--- io.insert-koin:koin-annotations:2.1.0 (*)
+|    |    +--- project :core:ui (*)
+|    |    +--- project :core:designsystem (*)
+|    |    +--- project :core:data (*)
+|    |    +--- io.insert-koin:koin-compose:4.1.1 (*)
+|    |    +--- io.insert-koin:koin-compose-viewmodel:4.1.1 (*)
+|    |    +--- org.jetbrains.compose.runtime:runtime:1.9.3 -> 1.10.1 (*)
+|    |    +--- org.jetbrains.androidx.lifecycle:lifecycle-runtime-compose:2.9.6 (*)
+|    |    +--- org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-compose:2.9.6 (*)
+|    |    +--- org.jetbrains.androidx.lifecycle:lifecycle-viewmodel:2.9.6 (*)
+|    |    +--- org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.6 (*)
+|    |    +--- org.jetbrains.androidx.savedstate:savedstate:1.4.0 (*)
+|    |    +--- org.jetbrains.androidx.core:core-bundle:1.0.1 (*)
+|    |    +--- org.jetbrains.androidx.navigation:navigation-compose:2.9.1 (*)
+|    |    +--- org.jetbrains.androidx.navigationevent:navigationevent-compose:1.0.1 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-collections-immutable:0.4.0 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.9.0 (*)
+|    |    +--- io.github.openmf:mifos-authenticator-passcode:2.3.0-beta (*)
+|    |    +--- io.github.openmf:mifos-authenticator-biometrics:2.3.0-beta (*)
+|    |    +--- org.jetbrains.compose.ui:ui:1.9.3 -> 1.10.1 (*)
+|    |    +--- org.jetbrains.compose.foundation:foundation:1.9.3 -> 1.10.0 (*)
+|    |    +--- org.jetbrains.compose.material3:material3:1.9.0-beta03 -> 1.9.0 (*)
+|    |    +--- org.jetbrains.compose.material:material-icons-extended:1.7.3 (*)
+|    |    +--- org.jetbrains.compose.components:components-resources:1.9.3 -> 1.10.0 (*)
+|    |    +--- org.jetbrains.compose.components:components-ui-tooling-preview:1.9.3 (*)
+|    |    +--- io.github.vinceglb:filekit-core:0.12.0 (*)
+|    |    +--- io.github.vinceglb:filekit-dialogs:0.12.0 (*)
+|    |    +--- io.github.vinceglb:filekit-dialogs-compose:0.12.0 (*)
+|    |    +--- io.github.niyajali:compose-signature:1.0.1
+|    |    |    \--- io.github.niyajali:compose-signature-android:1.0.1
+|    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+|    |    |         +--- org.jetbrains.compose.runtime:runtime:1.8.1 -> 1.10.1 (*)
+|    |    |         +--- org.jetbrains.compose.ui:ui:1.8.1 -> 1.10.1 (*)
+|    |    |         +--- org.jetbrains.compose.foundation:foundation:1.8.1 -> 1.10.0 (*)
+|    |    |         +--- org.jetbrains.compose.material3:material3:1.8.1 -> 1.9.0 (*)
+|    |    |         +--- org.jetbrains.compose.components:components-resources:1.8.1 -> 1.10.0 (*)
+|    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+|    |    |         \--- org.jetbrains.kotlinx:kotlinx-datetime:0.6.2 -> 0.7.1 (*)
+|    |    +--- project :core-base:ui (*)
+|    |    +--- project :core-base:common
+|    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.10.2 (*)
+|    |    |    +--- co.touchlab:kermit:2.0.8 (*)
+|    |    |    +--- com.squareup.okio:okio:3.16.4 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 (*)
+|    |    |    +--- org.jetbrains.kotlinx:kotlinx-datetime:0.7.1 (*)
+|    |    |    +--- io.insert-koin:koin-bom:4.1.1 (*)
+|    |    |    +--- io.insert-koin:koin-core:4.1.1 (*)
+|    |    |    +--- io.insert-koin:koin-annotations:2.1.0 (*)
+|    |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.2.21 (*)
+|    |    +--- project :core-base:network (*)
+|    |    +--- androidx.appcompat:appcompat:1.7.1 (*)
+|    |    \--- androidx.core:core-ktx:1.17.0 (*)
 |    \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.2.21 (*)
 +--- project :core:data (*)
 +--- project :core:ui (*)

cmp-android/dependencies/prodReleaseRuntimeClasspath.txt

@@ -1,4 +1,5 @@
 :cmp-shared
+:core-base:common
 :core-base:datastore
 :core-base:designsystem
 :core-base:network
@@ -40,6 +41,7 @@
 :feature:transfer-interbank
 :feature:transfer-intrabank
 :feature:upi-setup
+:libs:mifos-loans
 androidx.activity:activity-compose:1.12.2
 androidx.activity:activity-ktx:1.12.2
 androidx.activity:activity:1.12.2
@@ -344,6 +346,8 @@ io.github.jan-tennert.supabase:postgrest-kt-android:3.1.1
 io.github.jan-tennert.supabase:postgrest-kt:3.1.1
 io.github.jan-tennert.supabase:supabase-kt-android:3.1.1
 io.github.jan-tennert.supabase:supabase-kt:3.1.1
+io.github.niyajali:compose-signature-android:1.0.1
+io.github.niyajali:compose-signature:1.0.1
 io.github.openmf:mifos-authenticator-biometrics-android:2.3.0-beta
 io.github.openmf:mifos-authenticator-biometrics:2.3.0-beta
 io.github.openmf:mifos-authenticator-passcode-android:2.3.0-beta

cmp-shared/build.gradle.kts

@@ -60,6 +60,7 @@ kotlin {
             implementation(projects.feature.passcode)
             implementation(projects.feature.autopay)
             implementation(projects.feature.sendMoney)
+            implementation(projects.libs.mifosLoans)
         }
 
         desktopMain.dependencies {

cmp-shared/src/commonMain/kotlin/org/mifospay/shared/di/KoinModules.kt

@@ -16,6 +16,7 @@ import org.koin.dsl.koinApplication
 import org.koin.dsl.module
 import org.mifos.authenticator.passcode.PasscodeManager
 import org.mifos.feature.passcode.MifosAuthenticatorModule
+import org.mifos.lib.loan.di.LoanApplicationModule
 import org.mifospay.core.common.di.DispatchersModule
 import org.mifospay.core.common.di.stringProviderModule
 import org.mifospay.core.data.di.RepositoryModule
@@ -118,6 +119,7 @@ object KoinModules {
             MifosAuthenticatorModule,
             AutoPayModule,
             SendMoneyModule,
+            LoanApplicationModule,
         )
     }
 

cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt

@@ -23,6 +23,8 @@ import org.jetbrains.compose.resources.stringResource
 import org.koin.compose.koinInject
 import org.mifos.feature.passcode.internalMifosPasscodeScreen
 import org.mifos.feature.passcode.navigateToInternalMifosPasscodeScreen
+import org.mifos.lib.loan.navigation.loanApplicationGraph
+import org.mifos.lib.loan.navigation.navigateToLoanApplicationGraph
 import org.mifospay.core.data.repository.UserVerificationRepository
 import org.mifospay.core.ui.utility.TabContent
 import org.mifospay.feature.accounts.AccountsScreen
@@ -269,6 +271,9 @@ internal fun MifosNavHost(
                 onAddEditSavingsAccount = navController::navigateToSavingAccountAddEdit,
                 onViewSavingAccountDetails = navController::navigateToSavingAccountDetails,
                 onAddOrEditBeneficiary = navController::navigateToBeneficiaryAddEdit,
+                onApplyForLoanClick = { clientId ->
+                    navController.navigateToLoanApplicationGraph(clientId)
+                },
             )
         },
 
@@ -858,6 +863,22 @@ internal fun MifosNavHost(
             },
         )
 
+        loanApplicationGraph(
+            navController = navController,
+            navigateBack = navController::navigateUp,
+            navigateForPasscodeVerification = { verificationKey ->
+                navController.navigateToInternalMifosPasscodeScreen(verificationKey)
+            },
+            onSubmitSuccess = {
+                navController.navigate(FINANCE_ROUTE) {
+                    popUpTo(FINANCE_ROUTE) {
+                        inclusive = false
+                    }
+                    launchSingleTop = true
+                }
+            },
+        )
+
         transferSuccessScreen(
             navigateBack = { returnDestination ->
                 when (returnDestination) {

docs/LOAN_APPLICATION_ARCHITECTURE.md

@@ -0,0 +1,196 @@
+# Loan Application Feature — Architecture & Provider Selection
+
+## Overview
+
+`libs/mifos-loans` is a self-contained Kotlin Multiplatform module implementing a 6-step
+loan-application wizard, ported from mifos-mobile's `feature/loan-application` and re-architected
+so the app can plug in different lender backends behind a single UI flow.
+
+```
+Select Loan Provider → Select Loan Type → Loan Product Details → Loan Apply → Upload Docs → Confirm Details
+```
+
+The module owns its full vertical slice: domain models, its own Ktorfit network client, mappers,
+provider adapters, a repository facade, DI, and all 6 screens. The host app (`cmp-shared`) only
+knows about one entry point (`navigateToLoanApplicationGraph`) and one Koin module
+(`LoanApplicationModule`).
+
+---
+
+## Why a provider-selection step exists
+
+The product requirement was: tapping "Apply for Loan" should first show a choice of lenders
+(HDFC Bank, SBI, ICICI Bank, Axis Bank today — illustrative names, not live integrations), *then*
+proceed into the application flow. The rest of this document explains how that choice is threaded
+through the wizard and turned into an actual backend selection, even though today every provider
+still resolves to the same mock data.
+
+---
+
+## Package layout
+
+```
+libs/mifos-loans/src/commonMain/kotlin/org/mifos/lib/loan/
+├── core/                    LoanProvider interface + all domain models (LoanTemplate, LoansPayload, ...)
+├── network/                 Ktorfit LoansService + DTOs + the library's OWN Ktorfit engine (di/LoansNetworkModule.kt)
+├── mapper/                  DTO → domain model conversions
+├── providers/                Concrete LoanProvider adapters + the registry that resolves between them
+│   ├── FineractLoanProvider.kt    real Fineract-backed adapter (not active yet)
+│   ├── DummyLoanProvider.kt       mock adapter (currently backs every provider id)
+│   └── LoanProviderRegistry.kt    resolves a LoanProvider by providerId
+├── repository/
+│   ├── LoansRepository.kt         facade interface — this is what ViewModels inject
+│   └── LoansRepositoryImpl.kt     delegates every call to LoanProviderRegistry.resolve(providerId)
+├── di/LoanApplicationModule.kt    Koin bindings for all of the above + the 6 screen ViewModels
+├── ui/                            the 6 screens of the wizard
+│   ├── selectLoanProvider/            Screen 1
+│   ├── selectLoanType/                Screen 2
+│   ├── loanProductDetails/            Screen 3
+│   ├── loanApply/                     Screen 4
+│   ├── uploadDocs/                    Screen 5
+│   └── confirmDetails/                Screen 6
+├── navigation/LoanApplicationNavGraph.kt   wires all 6 screens together
+└── component/                     shared Compose UI pieces (LoanCard, etc.)
+```
+
+---
+
+## How `providerId` flows through the wizard
+
+**The core design decision:** the selected provider is carried as a plain field on every screen's
+navigation route (`providerId: String`) — the exact same mechanism already used for `clientId`.
+It is **not** a shared mutable singleton/holder.
+
+Why that matters: Android can kill the app process mid-flow (backgrounding, memory pressure). The
+nav backstack and each screen's arguments survive this via `SavedStateHandle` — a singleton held
+in a Koin container does not. Since this flow ends in a non-reversible submit, silently losing
+"which provider you were applying through" after a process restart would be a real correctness bug.
+Threading it through routes costs one extra field per screen and gets this for free.
+
+Concretely, every route in the chain looks like this (fields accumulate as the wizard progresses):
+
+```kotlin
+SelectLoanProviderRoute(clientId)
+SelectLoanTypeRoute(clientId, providerId)
+LoanProductDetailsRoute(clientId, productId, providerId)
+LoanApplyRoute(clientId, productId, providerId)
+UploadDocsRoute(clientId, productId, providerId, applicantName, loanProductName, loanPurpose, disbursementDate, principalAmount)
+ConfirmDetailsRoute(clientId, productId, providerId, applicantName, loanProductName, loanPurpose, disbursementDate, principalAmount)
+```
+
+Each screen's ViewModel reads `providerId` off its own route via `savedStateHandle.toRoute<XRoute>()`,
+keeps it in its UI state, and passes it forward when it navigates to the next screen — mirroring
+exactly how `clientId` and `productId` are already threaded.
+
+---
+
+## The resolution mechanism: registry + facade
+
+### 1. `LoanProvider` (interface, in `core/`) — unchanged, the seam every adapter implements
+
+```kotlin
+interface LoanProvider {
+    fun getLoanTemplate(clientId: Long): Flow<DataState<LoanTemplate>>
+    fun getLoanTemplateByProduct(clientId: Long, productId: Long): Flow<DataState<LoanTemplate>>
+    suspend fun submitLoanApplication(loanState: LoanState, payload: LoansPayload, loanId: Long): DataState<String>
+}
+```
+
+### 2. `providers/` — concrete adapters
+
+- **`DummyLoanProvider`** — no network calls, returns fabricated `LoanTemplate`/success data. Currently backs every provider id.
+- **`FineractLoanProvider`** — the real adapter, calls the library's own `LoansService` (Ktorfit) against the live Fineract self-service API. Built and wired, but not reachable from the UI today (see "Current state" below).
+
+### 3. `LoanProviderRegistry` — resolves an id to an adapter
+
+```kotlin
+class LoanProviderRegistry(
+    private val providersById: Map<String, LoanProvider>,
+    private val defaultProvider: LoanProvider,
+) {
+    fun resolve(providerId: String): LoanProvider = providersById[providerId] ?: defaultProvider
+}
+```
+
+Bound in `LoanApplicationModule.kt` today as:
+
+```kotlin
+providersById = mapOf(
+    "hdfc" to dummy,
+    "sbi" to dummy,
+    "icici" to dummy,
+    "axis" to dummy,
+    "fineract" to get<FineractLoanProvider>(),
+),
+defaultProvider = dummy,
+```
+
+All four UI-facing ids point at the **same** `DummyLoanProvider` instance — this is the "current
+state" honesty: selecting HDFC vs SBI vs ICICI vs Axis produces identical data today. `"fineract"`
+is registered and ready, just not selectable from the current 4-item provider list.
+
+### 4. `LoansRepository` — the facade ViewModels actually inject
+
+None of the 4 data-consuming ViewModels (`SelectLoanTypeViewModel`, `LoanProductDetailsViewModel`,
+`LoanApplyViewModel`, `ConfirmDetailsViewModel`) inject `LoanProvider` directly anymore. They inject
+`LoansRepository`, which takes `providerId` as a parameter on every call and resolves through the
+registry:
+
+```kotlin
+interface LoansRepository {
+    fun getLoanTemplate(providerId: String, clientId: Long): Flow<DataState<LoanTemplate>>
+    fun getLoanTemplateByProduct(providerId: String, clientId: Long, productId: Long): Flow<DataState<LoanTemplate>>
+    suspend fun submitLoanApplication(providerId: String, loanState: LoanState, payload: LoansPayload, loanId: Long): DataState<String>
+}
+```
+
+`LoansRepositoryImpl` is a one-line delegation: `registry.resolve(providerId).getLoanTemplate(clientId)`, etc.
+
+---
+
+## Walkthrough: user taps "SBI"
+
+1. **Select Loan Provider screen** — `SelectLoanProviderViewModel` holds a static list (`defaultLoanProviders`, ids `"hdfc"`/`"sbi"`/`"icici"`/`"axis"`). Tapping SBI dispatches `ProviderClicked("sbi")`, which now forwards `providerId = "sbi"` into the next navigation call (previously this was discarded — that was the bug fixed).
+2. **Select Loan Type screen** — receives `SelectLoanTypeRoute(clientId, providerId = "sbi")`. Its ViewModel calls `loansRepository.getLoanTemplate(providerId = "sbi", clientId)`. `LoansRepositoryImpl` calls `registry.resolve("sbi")` → returns the shared `DummyLoanProvider` → mock `LoanTemplate` comes back, screen renders the same product list it always does.
+3. **Loan Product Details / Loan Apply / Upload Docs** — each screen reads `providerId` off its own route and forwards it to the next, same as `clientId`.
+4. **Confirm Details screen** — on submit, calls `loansRepository.submitLoanApplication(providerId = "sbi", ...)` → resolves to `DummyLoanProvider` → returns a mock success `DataState.Success(...)`.
+
+If `FineractLoanProvider` were registered under `"sbi"` instead of the shared dummy, step 2 and 4
+above would transparently start hitting the real Fineract API — **no changes needed in any
+screen or ViewModel**, only in the one map entry inside `LoanApplicationModule.kt`.
+
+---
+
+## The library's own network engine
+
+`libs/mifos-loans` does not depend on the host app's `core/network` module for HTTP anymore.
+`network/di/LoansNetworkModule.kt` builds its own `Ktorfit` instance (qualifier `"LoansClient"`),
+using the same generic building blocks the app's own client uses:
+
+- `httpClient()` / `setupDefaultHttpClient()` / `DynamicBaseUrlPlugin` / `DynamicLoggableHosts` — generic Ktor plumbing from `core-base:network`
+- `KtorInterceptor` reading `UserPreferencesRepository.authToken` — so it still authenticates against the same logged-in session, just via its own client instance
+- `UrlType.SELF_SERVICE` — same Fineract self-service base URL the rest of the app uses
+
+`core/network` no longer contains any loan-specific code (`LoansService`, loan DTOs,
+`ApiEndPoints.LOANS` were all removed from it).
+
+---
+
+## Current state — what's real vs. placeholder
+
+| Piece | Status |
+|---|---|
+| 6-screen nav chain, `providerId` threading | Real, verified on-device |
+| `LoanProviderRegistry` / `LoansRepository` resolution mechanism | Real |
+| `DummyLoanProvider` bound for all 4 UI provider ids | Active (intentional — "no APIs for now") |
+| `FineractLoanProvider` + library's own Ktorfit engine | Built, compiles, registered under `"fineract"` — **not** wired to any UI-selectable provider |
+| Passcode/biometric gate before submit | Disabled (commented out in `ConfirmDetailsViewModel`, easy to restore) |
+| Fineract endpoint shapes (`loans/template?templateType=individual`, `POST loans`) | Ported as-is from mifos-mobile — **do not yet match** the simpler ticket-specified shape (`GET /self/loanproducts`, `POST /self/loans`, `GET /self/loans/{id}`, `POST /self/loans/{id}/transactions`) — deferred by request |
+
+## To activate a real provider later
+
+1. Build a concrete `LoanProvider` implementation (can reuse `FineractLoanProvider` if the ticket's
+   simpler endpoint shape is implemented on `LoansService`, or write a new adapter class in `providers/`).
+2. Bind it in `LoanApplicationModule.kt` and swap the relevant entry in `LoanProviderRegistry`'s
+   `providersById` map (e.g. `"sbi" to get<SbiLoanProvider>()` instead of `"sbi" to dummy`).
+3. Nothing else changes — no screen, ViewModel, or route touches a concrete provider type directly.

feature/accounts/src/commonMain/composeResources/values-es/strings.xml

@@ -58,6 +58,7 @@
     <string name="feature_accounts_default">Predeterminada</string>
     <string name="feature_accounts_edit_beneficiary">Editar beneficiario</string>
     <string name="feature_accounts_delete_beneficiary">Eliminar beneficiario</string>
+    <string name="feature_accounts_apply_for_loan">Solicitar préstamo</string>
 
     <string name="feature_accounts_status_pending_approval">Pendiente de aprobación</string>
     <string name="feature_accounts_status_approved">Aprobada</string>

feature/accounts/src/commonMain/composeResources/values/strings.xml

@@ -59,6 +59,7 @@
     <string name="feature_accounts_default">Default</string>
     <string name="feature_accounts_edit_beneficiary">Edit Beneficiary</string>
     <string name="feature_accounts_delete_beneficiary">Delete Beneficiary</string>
+    <string name="feature_accounts_apply_for_loan">Apply for Loan</string>
 
     <!-- Status chips -->
     <string name="feature_accounts_status_pending_approval">Pending Approval</string>