Improve response handling and type annotations #742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertschweizer
force-pushed
the
improve-return-type-annotations
branch
from
c9964ee to
204e2c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #742 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1978 1985 +7
=========================================
+ Hits 1978 1985 +7 ☔ View full report in Codecov by Sentry. |
robertschweizer
force-pushed
the
improve-return-type-annotations
branch
from
204e2c8 to
81de00f
Compare
We know the type of this: It's `None`, so we don't need to annotate it as `Any`.
cast(None, None) made mypy fail after that last commit.
It makes sense to return the parsed JSON here instead of None.
This was introduced in "fix: Make empty response a `NoneProperty`", but is easier to fix now since parsed_responses in endpoint_module.py.jinja does not include `Any` response types anymore.
robertschweizer
force-pushed
the
improve-return-type-annotations
branch
from
81de00f to
90aba2c
Compare
Also prevents double return type annotations like `Optional[None]`.
robertschweizer
force-pushed
the
improve-return-type-annotations
branch
from
90aba2c to
afa1de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details