-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ca: Create new files for current, abolished and renamed OCD-IDs #324
Conversation
Looks great, we should also rename Are the TODOs something you'd like help with @jpmckinney? |
Sounds good. Yes, I wanted to get agreement on what I had so far before completing the TODOs. We can rename the old files (those IDs will be aliases to the new ones), and document the naming policy in the readme. The Ruby scripts for those IDs would be removed, as the Python script is now responsible for federal IDs. |
I can work on the TODOs in the Python script, if you can help with aliasing the current federal IDs ( |
Sounds good, I'll also update the README and rename/clean up old files. |
I don't seem to have access to push to this branch/repo. Here is a file containing aliases of current federal IDs. |
@evannjw I don't have much time this week for this PR, so if you can help with the other items, please have a look. |
Sure I can wrap up the remaining TODOs here |
Hi sorry, haven't actually had time to work on this, should be able to get to this tomorrow/early next week |
@jpmckinney All of this LGTM. Thanks to you and @evannjw for putting this together. I support this approach. |
Replaced by #327 |
This PR implements a naming policy co-created with @evannjw in #323.
In brief:
To complete the PR: