Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

323 canada fed rename #327

Merged

Conversation

evannjw
Copy link
Contributor

@evannjw evannjw commented Nov 30, 2022

Cleaned up conflicting aliases and completed TODOs on draft pr.
For missing sameAs, these were moved to abolished districts csv as there is no clear source to use to address these.

closes #323 (which followed from #320)
replaces #324

@evannjw
Copy link
Contributor Author

evannjw commented Dec 14, 2022

@jpmckinney Can you take a look?

@jpmckinney
Copy link
Member

Thank you for the ping – I'll try to have a look soon.

Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look and these changes LGTM. Added one nitpick for documentation which might be helpful to future editors

identifiers/country-ca/README.md Show resolved Hide resolved
@evannjw
Copy link
Contributor Author

evannjw commented Jan 19, 2023

@jpmckinney Hi sorry to ping again, would you be able to review in the next week or two?

@jpmckinney
Copy link
Member

I'll try this weekend!

@jpmckinney
Copy link
Member

I haven't had time to review, but if this is time-sensitive, happy for another reviewer to merge.

@evannjw
Copy link
Contributor Author

evannjw commented Jan 31, 2023

@DrMeers Would you be able to review and merge?

@DrMeers
Copy link
Contributor

DrMeers commented Jan 31, 2023

@DrMeers Would you be able to review and merge?

Unfortunately I lack both the knowledge and the permissions to do so

@jloutsenhizer
Copy link
Contributor

@opencivicdata/division-id-curators could someone provide a second review for this PR? Thanks

@evannjw
Copy link
Contributor Author

evannjw commented May 31, 2023

This has been sitting around for while now, any chance you could review this sometime this/next week @jpmckinney?

@jpmckinney
Copy link
Member

It doesn't look like I'll have time to review properly, so feel free to merge as-is. I expect that at most there might be a few individual corrections. My projects will continue to use aliases for now, as I don't have time to transition to new IDs.

@NikolasYo
Copy link
Contributor

Thanks for the ping. As we reviewed with @zikowang it seems okay.

@jpmckinney jpmckinney merged commit 2939706 into opencivicdata:323-canada-fed-rename Jan 28, 2024
@zikowang
Copy link
Contributor

zikowang commented Feb 8, 2024

@evannjw @jpmckinney this branch was merged into https://github.com/opencivicdata/ocd-division-ids/tree/323-canada-fed-rename, is it correct? Shouldn't it be merged into master?

I would continue working on #364 after the merge.

@jpmckinney
Copy link
Member

Ah, yes, I hadn't noticed that.

@jpmckinney
Copy link
Member

I opened a new PR. Can you resolve the conflicts in #365?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants