-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
323 canada fed rename #327
323 canada fed rename #327
Conversation
@jpmckinney Can you take a look? |
Thank you for the ping – I'll try to have a look soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a quick look and these changes LGTM. Added one nitpick for documentation which might be helpful to future editors
@jpmckinney Hi sorry to ping again, would you be able to review in the next week or two? |
I'll try this weekend! |
I haven't had time to review, but if this is time-sensitive, happy for another reviewer to merge. |
@DrMeers Would you be able to review and merge? |
Unfortunately I lack both the knowledge and the permissions to do so |
@opencivicdata/division-id-curators could someone provide a second review for this PR? Thanks |
This has been sitting around for while now, any chance you could review this sometime this/next week @jpmckinney? |
It doesn't look like I'll have time to review properly, so feel free to merge as-is. I expect that at most there might be a few individual corrections. My projects will continue to use aliases for now, as I don't have time to transition to new IDs. |
Thanks for the ping. As we reviewed with @zikowang it seems okay. |
@evannjw @jpmckinney this branch was merged into https://github.com/opencivicdata/ocd-division-ids/tree/323-canada-fed-rename, is it correct? Shouldn't it be merged into I would continue working on #364 after the merge. |
Ah, yes, I hadn't noticed that. |
I opened a new PR. Can you resolve the conflicts in #365? |
Cleaned up conflicting aliases and completed TODOs on draft pr.
For missing sameAs, these were moved to abolished districts csv as there is no clear source to use to address these.
closes #323 (which followed from #320)
replaces #324