Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a variable for minio-service endpoint #479

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Adding a variable for minio-service endpoint #479

merged 1 commit into from
Nov 21, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Nov 16, 2023

The issue resolved by this Pull Request:

Resolves #375

Description of your changes:

Replacing hardcode references to minio-service endpoints with an environment variable.

Testing instructions

  • Build an image with changes in this PR. This is the image I built with these changes: quay.io/rhn_support_ddalvi/data-science-pipelines-operator:minio-revised
  • Deploy DSPO and create a DSPA instance
  • Make sure minio pod comes up correctly
  • Create a run using the default pipeline to make sure it goes through correctly.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from gmfrasca and rimolive November 16, 2023 22:34
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-479
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/479/head
git checkout -b pullrequest 89fb58911d701a1ff99da72cfbe74b5ab85aebd2
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-479"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-479

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-479

Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5dbf012 into opendatahub-io:main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSPv2] Investigate/Update/Remove minio-service annotation (tekton.dev/artifact_endpoint)
3 participants