-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a variable for minio-service endpoint #479
Adding a variable for minio-service endpoint #479
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/479/head
git checkout -b pullrequest 89fb58911d701a1ff99da72cfbe74b5ab85aebd2
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-479" More instructions here on how to deploy and test a Data Science Pipelines Application. |
controllers/testdata/declarative/case_2/expected/created/sample-pipeline.yaml.tmpl
Outdated
Show resolved
Hide resolved
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmfrasca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves #375
Description of your changes:
Replacing hardcode references to minio-service endpoints with an environment variable.
Testing instructions
quay.io/rhn_support_ddalvi/data-science-pipelines-operator:minio-revised
Checklist