HOLD: add label to NS

[cooktheryan]

Add label to namespace for better RHOAI experience.

HOLD until I can test

Summary by CodeRabbit

• Chores
  • Introduced a new Kubernetes namespace label for llama-serve, standardizing environment metadata and ensuring predictable behavior across deployments. The label is set to a conservative default and does not alter existing annotations or resource identifiers. This change does not affect current user workflows or interfaces but improves operational clarity and enables future configuration adjustments without service disruption.

[coderabbitai]

Walkthrough

Added a new string label modelmesh-enabled: 'false' under metadata.labels to the Kubernetes Namespace manifest at kubernetes/namespace/namespace.yaml. All other fields remain unchanged.

Changes

Cohort / File(s)	Summary
Kubernetes Namespace label update kubernetes/namespace/namespace.yaml	Added metadata.labels entry: modelmesh-enabled: 'false'. No other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my whiskers, configs neat,
A label added—small and sweet.
modelmesh sleeps, set to false,
In namespaces where clusters waltz.
Hop, commit, and off I dash—
Another tidy YAML stash! 🐇✨

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch model_mesh

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

kubernetes/namespace/namespace.yaml (1)

7-8: Confirm intended semantics for modelmesh-enabled label value

Double-check that setting modelmesh-enabled to "false" is the intended behavior for your RHOAI/ModelMesh integration. Some controllers look for "true" to enable behavior and ignore or default otherwise. Please verify the expected effect in your environment before merging.

I can help adjust this manifest or add a Kustomize patch across environments once you confirm the desired behavior.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1c15df and 510e965.

📒 Files selected for processing (1)

• kubernetes/namespace/namespace.yaml (1 hunks)

[coderabbitai]

⚠️ Potential issue

Fix: labels are incorrectly nested under annotations; move to metadata.labels

In Kubernetes, metadata.annotations values must be strings, and labels must be a sibling of annotations under metadata. As written, this will fail validation (annotations contains an object-valued key "labels"). Place labels directly under metadata.

Apply this diff to correct the structure:

 metadata:
   name: llama-serve
-  annotations:
-    argocd.argoproj.io/sync-wave: "0"
-    labels:
-      modelmesh-enabled: 'false'
+  labels:
+    modelmesh-enabled: "false"
+  annotations:
+    argocd.argoproj.io/sync-wave: "0"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	labels:
	modelmesh-enabled: 'false'
	metadata:
	name: llama-serve
	labels:
	modelmesh-enabled: "false"
	annotations:
	argocd.argoproj.io/sync-wave: "0"

🤖 Prompt for AI Agents

In kubernetes/namespace/namespace.yaml around lines 7 to 8, the labels block is
mistakenly placed under metadata.annotations (creating an object-valued
annotation) which breaks validation; move the labels map out of annotations and
place it as a sibling under metadata.labels with string values (e.g.,
modelmesh-enabled: "false"), removing the labels key from annotations so
annotations contains only string key:value pairs.