RHOAIENG-16403: chore(Makefile): implement .ONESHELL: and .SHELLFLAGS := -eu -o pipefail -c in Makefile

[jiridanek]

https://issues.redhat.com/browse/RHOAIENG-16403

Description

https://tech.davis-hansson.com/p/make/ says all this is a good idea

Currently we have this

• RHOAIENG-16149: chore(Makefile): implement advice from avis-hansson.com/p/make/ #778

# https://tech.davis-hansson.com/p/make/
SHELL := bash
# todo: do not set .ONESHELL: for now
# http://redsymbol.net/articles/unofficial-bash-strict-mode/
#.SHELLFLAGS := -eu -o pipefail -c
.DELETE_ON_ERROR:
MAKEFLAGS += --warn-undefined-variables
MAKEFLAGS += --no-builtin-rules

# todo: leave the default recipe prefix for now
ifeq ($(origin .RECIPEPREFIX), undefined)
  $(error This Make does not support .RECIPEPREFIX. Please use GNU Make 4.0 or later)
endif
.RECIPEPREFIX =

Let's uncomment the shell-related parts.

How Has This Been Tested?

• https://github.com/jiridanek/notebooks/actions/runs/12315841291

I've modified the code where necessary so that no new test failures are being reported.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[jiridanek]

/retest-required

[caponetto]

/lgtm

[jiridanek]

/override ci/prow/images
/approve
thanks

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jiridanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
/approve
thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.