Skip to content

Commit

Permalink
feat(mr): remove separate MODEL_REGISTRY_SETTINGS area
Browse files Browse the repository at this point in the history
Signed-off-by: gitdallas <[email protected]>
  • Loading branch information
gitdallas committed May 13, 2024
1 parent ca003db commit b008beb
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
6 changes: 1 addition & 5 deletions frontend/src/concepts/areas/const.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@ export const SupportedAreasStateMap: SupportedAreasState = {
[SupportedArea.CLUSTER_SETTINGS]: {
featureFlags: ['disableClusterManager'],
},
[SupportedArea.MODEL_REGISTRY_SETTINGS]: {
featureFlags: ['disableModelRegistry'],
requiredComponents: [StackComponent.MODEL_REGISTRY],
requiredCapabilities: [StackCapability.SERVICE_MESH, StackCapability.SERVICE_MESH_AUTHZ],
},
[SupportedArea.CUSTOM_RUNTIMES]: {
featureFlags: ['disableCustomServingRuntimes'],
reliantAreas: [SupportedArea.MODEL_SERVING],
Expand Down Expand Up @@ -82,5 +77,6 @@ export const SupportedAreasStateMap: SupportedAreasState = {
[SupportedArea.MODEL_REGISTRY]: {
featureFlags: ['disableModelRegistry'],
requiredComponents: [StackComponent.MODEL_REGISTRY],
requiredCapabilities: [StackCapability.SERVICE_MESH, StackCapability.SERVICE_MESH_AUTHZ],
},
};
1 change: 0 additions & 1 deletion frontend/src/concepts/areas/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export enum SupportedArea {
/* Admin areas */
BYON = 'bring-your-own-notebook',
CLUSTER_SETTINGS = 'cluster-settings',
MODEL_REGISTRY_SETTINGS = 'model-registry-settings',
USER_MANAGEMENT = 'user-management',
ACCELERATOR_PROFILES = 'accelerator-profiles',

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/utilities/NavData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ const useCustomRuntimesNav = (): NavDataHref[] =>
]);

const useModelRegisterySettingsNav = (): NavDataHref[] =>
useAreaCheck<NavDataHref>(SupportedArea.MODEL_REGISTRY_SETTINGS, [
useAreaCheck<NavDataHref>(SupportedArea.MODEL_REGISTRY, [
{
id: 'settings-model-registry',
label: 'Model registry settings',
Expand Down

0 comments on commit b008beb

Please sign in to comment.