update breadcrumb title for edit connection type page (#3220)

opendatahub-io · Sep 18, 2024 · fa9e57f · fa9e57f
1 parent 3a39387
commit fa9e57f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/frontend/src/__tests__/cypress/cypress/pages/connectionTypes.ts b/frontend/src/__tests__/cypress/cypress/pages/connectionTypes.ts
@@ -53,7 +53,7 @@ class CreateConnectionTypePage {
 
   visitEditPage(name = 'existing') {
     cy.visitWithLogin(`/connectionTypes/edit/${name}`);
-    cy.findAllByText('Create connection type').should('exist');
+    cy.findAllByText('Edit connection type').should('exist');
   }
 
   findConnectionTypeName() {

diff --git a/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeBreadcrumbs.tsx b/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeBreadcrumbs.tsx
@@ -2,12 +2,16 @@ import * as React from 'react';
 import { Breadcrumb, BreadcrumbItem } from '@patternfly/react-core';
 import { Link } from 'react-router-dom';
 
-const ManageConnectionTypeBreadcrumbs: React.FunctionComponent = () => (
+type Props = {
+  name: string;
+};
+
+const ManageConnectionTypeBreadcrumbs: React.FC<Props> = ({ name }) => (
   <Breadcrumb ouiaId="BasicBreadcrumb">
     <BreadcrumbItem>
       <Link to="/connectionTypes">Connection types</Link>
     </BreadcrumbItem>
-    <BreadcrumbItem isActive>Create connection type</BreadcrumbItem>
+    <BreadcrumbItem isActive>{name}</BreadcrumbItem>
   </Breadcrumb>
 );
 

diff --git a/frontend/src/pages/connectionTypes/manage/ManageConnectionTypePage.tsx b/frontend/src/pages/connectionTypes/manage/ManageConnectionTypePage.tsx
@@ -103,18 +103,19 @@ const ManageConnectionTypePage: React.FC<Props> = ({ prefill, isEdit, onSave })
     navigate('/connectionTypes');
   };
 
+  const pageName = isEdit ? 'Edit connection type' : 'Create connection type';
   return (
     <ConnectionTypePreviewDrawer
       isExpanded={isDrawerExpanded}
       onClose={() => setIsDrawerExpanded(false)}
       obj={connectionTypeObj}
     >
       <ApplicationsPage
-        title={isEdit ? 'Edit connection type' : 'Create connection type'}
+        title={pageName}
         loaded
         empty={false}
         errorMessage="Unable to load connection types"
-        breadcrumb={<ManageConnectionTypeBreadcrumbs />}
+        breadcrumb={<ManageConnectionTypeBreadcrumbs name={pageName} />}
         headerAction={
           isDrawerExpanded ? undefined : (
             <Button