Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map accelerators to custom notebook images #1439

Closed
Gkrumbach07 opened this issue Jun 27, 2023 · 3 comments · Fixed by #2077
Closed

Map accelerators to custom notebook images #1439

Gkrumbach07 opened this issue Jun 27, 2023 · 3 comments · Fixed by #2077
Assignees
Labels
feature/accelerator-support All things related to Accelerators feature/adminui Admin UI Feature feature/byon Bring Your Own Notebook Feature kind/enhancement New functionality request (existing augments or new additions) priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Jun 27, 2023

Goal

Be able to visualize and configure images accelerators mappings from the custom notebook images page and table

Dependency issue

Itemized goals

  • add supported accelerators column
  • mapped accelerators are when a imagestream has the recommend accelerators annotation and that identiifer mathces one of the accelerator profiles
  • images with accelerators mapped but no matching accelerators should show a button to add a accelerator. this navigates to the create accelerator page with identifier filled in and disabled. matching accelerators are added as labels and the button does not go away
  • images that are OOTB with no mapped accelerators should show N/A
  • images that are OOTB with mapped accelerators should show labels of the accelerator profiles with no button
  • images without accelerators mapped should show the add button that is greyed out with a tooltip
  • no dragable image list unless that is already implemented
  • create/edit form should have a new section
    • section should allow you to add multiple identifiers
    • identifiers can be removed easily
    • dropdown identifiers from identifiers found in accelerators
    • also allow to type your own

Aspects continued elsewhere

No response

Mocks

https://www.sketch.com/s/c8183f89-76f5-4a23-b885-a9e404a61414/a/aMV90OP

@Gkrumbach07 Gkrumbach07 added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/byon Bring Your Own Notebook Feature feature/adminui Admin UI Feature feature/accelerator-support All things related to Accelerators labels Jun 27, 2023
@Gkrumbach07 Gkrumbach07 added this to the Accelerator Support milestone Jun 27, 2023
@Gkrumbach07 Gkrumbach07 added the kind/enhancement New functionality request (existing augments or new additions) label Jun 27, 2023
@Gkrumbach07
Copy link
Member Author

Needs UX

@yannnz

I believe this is where you last were working for the notebook image admin page

This issue will be on hold until more solidified details on the use of group labels

@yannnz
Copy link

yannnz commented Oct 16, 2023

Needs UX

@yannnz

I believe this is where you last were working for the notebook image admin page

This issue will be on hold until more solidified details on the use of group labels

Yes that link is the latest one.

@Gkrumbach07
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accelerator-support All things related to Accelerators feature/adminui Admin UI Feature feature/byon Bring Your Own Notebook Feature kind/enhancement New functionality request (existing augments or new additions) priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants