Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp Model framework label text #1492

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Revamp Model framework label text #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions frontend/src/__tests__/integration/pages/modelServing/ModelServingGlobal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,8 @@ test('Create model', async ({ page }) => {
await page.getByLabel('Model Name *').fill('Test Name');
await page.locator('#inference-service-model-selection').click();
await page.getByRole('option', { name: 'ovms' }).click();
await page
.getByText(
'Project Test ProjectModel Name * Model servers * OVMS Model ServingModel framework * Sel',
)
.click();
await expect(page.getByText('Model framework (name - version)')).toBeTruthy();
await page.locator('#inference-service-framework-selection').click();
await page.getByRole('option', { name: 'onnx - 1' }).click();
await expect(await page.getByRole('button', { name: 'Deploy' })).toBeDisabled();
await page
Expand Down
2 changes: 1 addition & 1 deletion .../modelServing/screens/projects/InferenceServiceModal/InferenceServiceFrameworkSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const InferenceServiceFrameworkSection: React.FC<InferenceServiceFrameworkSectio
}

return (
<FormGroup label="Model framework" isRequired>
<FormGroup label="Model framework (name - version)" isRequired>
<Select
removeFindDomNode
toggleId="inference-service-framework-selection"
Expand Down
Loading