Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Model framework label text #1492

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Jul 10, 2023

Description

Closes #1458

How Has This Been Tested?

  1. Go to DS Project
  2. Deploy a model server
  3. Go to the Deploy model modal
  4. Check that the Model framework label now is displayed as Model framework (name - version)
Screenshot 2023-07-10 at 13 37 35

Test Impact

Added extra steps in integration of Create model

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux
Copy link
Contributor Author

@vconzola I'm only changing the field label as you suggested, we've discussed this internally but let me know if it's ok!

@lucferbux
Copy link
Contributor Author

Ok, based on internal conversations, this PR should be ready to go!

@andrewballantyne
Copy link
Member

/lgtm

Screenshot looks great.

@vconzola
Copy link

vconzola commented Jul 11, 2023

LGTM.

@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 58d77f1 into opendatahub-io:main Jul 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OOTB model serving framework descriptions are not intuitive
5 participants