[RHOAIENG-10312] Connection type table view #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilys314
reviewed
Aug 6, 2024
jeff-phillips-18
force-pushed
the
connection-type-table
branch
from
de18c50
to
9e9c333
Compare
emilys314
reviewed
Aug 6, 2024
emilys314
reviewed
Aug 6, 2024
jeff-phillips-18
force-pushed
the
connection-type-table
branch
2 times, most recently
from
d033eeb
to
58cbe32
Compare
|
Everything is looking good to me /lgtm |
|
/lgtm |
|
/approve |
7 tasks
jeff-phillips-18
force-pushed
the
connection-type-table
branch
from
58cbe32
to
749d1fa
Compare
6 tasks
frontend/src/__tests__/cypress/cypress/tests/mocked/connectionTypes/connectionTypes.cy.ts
Outdated
Show resolved
Hide resolved
jeff-phillips-18
force-pushed
the
connection-type-table
branch
3 times, most recently
from
f29765b
to
97b3150
Compare
frontend/src/pages/pipelines/global/experiments/executions/ExecutionsTableToolbar.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/create/DuplicateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
jeff-phillips-18
force-pushed
the
connection-type-table
branch
from
97b3150
to
70bc9a9
Compare
6 tasks
jeff-phillips-18
force-pushed
the
connection-type-table
branch
from
70bc9a9
to
c522a89
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, manosnoam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RHOAIENG-10312
Description
Adds the initial version of the Connection Types view.
How Has This Been Tested?
Login as a product admin, set the devFeaturesFlag on and then uncheck
disableConnectionTypes, navigate to Settings -> Connection typesTest Impact
Added cypress e2e tests
Screenshots
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
/cc @simrandhaliw