Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of imagePullSecrets field in RHOAI deployment #3230

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 19, 2024

JIRA: RHOAIENG-10782

Description

This field was probably an old value and could be removed not to avoid the warnings.

How Has This Been Tested?

  1. Get a 4.15+ OpenShift cluster
  2. Install RHOAI operator on it and create the DSC
  3. Check the warning events on the cluster, you should be able to see Unable to retrieve some image pull secrets (addon-managed-odh-pullsecret);
  4. Go to DSC, edit dashboard entry to
dashboard:
  devFlags:
    manifests:
      - contextDir: manifests
        sourcePath: ''
        uri: 'https://github.com/DaoDaoNoCode/odh-dashboard/tarball/jira-rhoaieng-10782'
  1. The deployment will start to rollout
  2. Make sure there is no warning event above
  3. Make sure the dashboard can still running normally

Test Impact

N/A, manifest change.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (a3f9ef8) to head (8283fa3).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3230      +/-   ##
==========================================
+ Coverage   85.47%   85.49%   +0.01%     
==========================================
  Files        1279     1280       +1     
  Lines       28161    28190      +29     
  Branches     7525     7535      +10     
==========================================
+ Hits        24071    24101      +30     
+ Misses       4090     4089       -1     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f9ef8...8283fa3. Read the comment docs.

@DaoDaoNoCode
Copy link
Member Author

DaoDaoNoCode commented Sep 20, 2024

Verified on managed cluster.

Before:

Screenshot 2024-09-20 at 11 19 41 AM

After:

Screenshot 2024-09-20 at 11 23 53 AM

No warnings

And I can access the dashboard normally. (Not sure why it's Open Data Hub, maybe it's because I changed the manifest directly? 🤔 )

Screenshot 2024-09-20 at 11 57 25 AM

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5640b39 into opendatahub-io:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants