Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of imagePullSecrets field in RHOAI deployment #3230

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Get rid of imagePullSecrets field in RHOAI deployment #3230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb44d99
Get rid of imagePullSecrets field in RHOAI deployment
DaoDaoNoCode Sep 19, 2024
8283fa3
Remove this field in NIM and Anaconda
DaoDaoNoCode Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions manifests/rhoai/shared/base/anaconda-ce-validator-cron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ spec:
parent: "anaconda-ce-periodic-validator"
spec:
serviceAccount: "rhods-dashboard"
imagePullSecrets:
- name: addon-managed-odh-pullsecret
containers:
- name: anaconda-ce-validator
image: registry.redhat.io/openshift4/ose-cli@sha256:75bf9b911b6481dcf29f7942240d1555adaa607eec7fc61bedb7f624f87c36d4
Expand Down
4 changes: 0 additions & 4 deletions manifests/rhoai/shared/base/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,3 @@
- op: replace
path: /spec/template/spec/serviceAccount
value: rhods-dashboard
- op: replace
path: /spec/template/spec/imagePullSecrets
value:
- name: addon-managed-odh-pullsecret
andrewballantyne marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 0 additions & 2 deletions manifests/rhoai/shared/base/nvidia-nim-validator-cron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ spec:
parent: "nvidia-nim-periodic-validator"
spec:
serviceAccount: "rhods-dashboard"
imagePullSecrets:
- name: addon-managed-odh-pullsecret
containers:
- name: nvidia-nim-validator
image: registry.redhat.io/openshift4/ose-cli@sha256:75bf9b911b6481dcf29f7942240d1555adaa607eec7fc61bedb7f624f87c36d4
Expand Down
Loading