Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIM deployment #3265

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

olavtar
Copy link
Contributor

@olavtar olavtar commented Sep 26, 2024

https://issues.redhat.com/browse/APPENG-2712

Description

Added secret deletion and deploy button links fixed in empty state to point to NIM modal.

How Has This Been Tested?

Tested locally.

Test Impact

Verified resource creation and deletion during model deployment and removal.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Sep 26, 2024
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andrewballantyne
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Sep 26, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 comment on code -- let me test; also see to any CI failures

Comment on lines +77 to +82
deleteSecret(project.metadata.name, nimSecretName),
deleteSecret(project.metadata.name, imagePullSecretName),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. if you don't find these names, you'll fire off requests to no effect -- probably could write this logic a little more defensive and build out something to spread into the Promise.all before based on the various conditions

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (a0d40fd) to head (6428443).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ing/screens/global/DeleteInferenceServiceModal.tsx 64.28% 5 Missing ⚠️
...lServing/screens/projects/ModelServingPlatform.tsx 25.00% 3 Missing ⚠️
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 0.00% 1 Missing ⚠️
...rc/pages/modelServing/screens/projects/nimUtils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3265      +/-   ##
==========================================
- Coverage   84.96%   84.96%   -0.01%     
==========================================
  Files        1302     1302              
  Lines       29101    29120      +19     
  Branches     7828     7843      +15     
==========================================
+ Hits        24727    24742      +15     
- Misses       4374     4378       +4     
Files with missing lines Coverage Δ
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
...s/projects/NIMServiceModal/NIMModelListSection.tsx 1.63% <ø> (ø)
...verModels/deployedModels/DeployedModelsSection.tsx 100.00% <100.00%> (ø)
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 5.94% <0.00%> (ø)
...rc/pages/modelServing/screens/projects/nimUtils.ts 52.27% <50.00%> (ø)
...lServing/screens/projects/ModelServingPlatform.tsx 91.48% <25.00%> (-2.96%) ⬇️
...ing/screens/global/DeleteInferenceServiceModal.tsx 76.47% <64.28%> (-4.62%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d40fd...6428443. Read the comment docs.

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2024
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Member

/override ci/prow/images
/override ci/prow/odh-dashboard-pr-image-mirror

Needing this to merge -- not sure why it's having issues on completing the image. Another no-need for the image. Once the PR is merged we should have one built off main.

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@andrewballantyne: Overrode contexts on behalf of andrewballantyne: ci/prow/images, ci/prow/odh-dashboard-pr-image-mirror

In response to this:

/override ci/prow/images
/override ci/prow/odh-dashboard-pr-image-mirror

Needing this to merge -- not sure why it's having issues on completing the image. Another no-need for the image. Once the PR is merged we should have one built off main.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 73b0c4c into opendatahub-io:main Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants