-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIM deployment #3265
NIM deployment #3265
Conversation
Hi @olavtar. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 1 comment on code -- let me test; also see to any CI failures
deleteSecret(project.metadata.name, nimSecretName), | ||
deleteSecret(project.metadata.name, imagePullSecretName), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. if you don't find these names, you'll fire off requests to no effect -- probably could write this logic a little more defensive and build out something to spread into the Promise.all
before based on the various conditions
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
Signed-off-by: Olga Lavtar <[email protected]>
b5273ae
to
6428443
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
- Coverage 84.96% 84.96% -0.01%
==========================================
Files 1302 1302
Lines 29101 29120 +19
Branches 7828 7843 +15
==========================================
+ Hits 24727 24742 +15
- Misses 4374 4378 +4
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images Needing this to merge -- not sure why it's having issues on completing the image. Another no-need for the image. Once the PR is merged we should have one built off main. |
@andrewballantyne: Overrode contexts on behalf of andrewballantyne: ci/prow/images, ci/prow/odh-dashboard-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/APPENG-2712
Description
Added secret deletion and deploy button links fixed in empty state to point to NIM modal.
How Has This Been Tested?
Tested locally.
Test Impact
Verified resource creation and deletion during model deployment and removal.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main