NIM deployment

frontend/src/k8sTypes.ts

@@ -410,6 +410,16 @@ export type ServingContainer = {
   affinity?: PodAffinity;
   resources?: ContainerResources;
   volumeMounts?: VolumeMount[];
+  env?: {
+    name: string;
+    value?: string;
+    valueFrom?: {
+      secretKeyRef?: {
+        name: string;
+        key: string;
+      };
+    };
+  }[];
 };
 
 export type ServingRuntimeKind = K8sResourceCommon & {
@@ -430,6 +440,7 @@ export type ServingRuntimeKind = K8sResourceCommon & {
     replicas?: number;
     tolerations?: Toleration[];
     volumes?: Volume[];
+    imagePullSecrets?: { name: string }[];
   };
 };
 

frontend/src/pages/modelServing/screens/global/DeleteInferenceServiceModal.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import DeleteModal from '~/pages/projects/components/DeleteModal';
 import { InferenceServiceKind, ServingRuntimeKind } from '~/k8sTypes';
-import { deleteInferenceService, deletePvc, deleteServingRuntime } from '~/api';
+import { deleteInferenceService, deletePvc, deleteSecret, deleteServingRuntime } from '~/api';
 import { getDisplayNameFromK8sResource } from '~/concepts/k8s/utils';
 import { byName, ProjectsContext } from '~/concepts/projects/ProjectsContext';
 import { isProjectNIMSupported } from '~/pages/modelServing/screens/projects/nimUtils';
@@ -48,6 +48,14 @@
           const pvcName = servingRuntime?.spec.volumes?.find(
             (vol) => vol.persistentVolumeClaim?.claimName,
           )?.persistentVolumeClaim?.claimName;
+          const containerWithEnv = servingRuntime?.spec.containers.find(
+            (container) =>
+              container.env && container.env.some((env) => env.valueFrom?.secretKeyRef?.name),
+          );
+          const nimSecretName = containerWithEnv?.env?.find(
+            (env) => env.valueFrom?.secretKeyRef?.name,
+          )?.valueFrom?.secretKeyRef?.name;
+          const imagePullSecretName = servingRuntime?.spec.imagePullSecrets?.[0]?.name ?? '';
           Promise.all([
             deleteInferenceService(
               inferenceService.metadata.name,
@@ -64,6 +72,16 @@
             ...(isKServeNIMEnabled && pvcName
               ? [deletePvc(pvcName, inferenceService.metadata.namespace)]
               : []),
+            ...(isKServeNIMEnabled &&
+            project &&
+            nimSecretName &&
+            nimSecretName.length > 0 &&
+            imagePullSecretName.length > 0
+              ? [
+                  deleteSecret(project.metadata.name, nimSecretName),
+                  deleteSecret(project.metadata.name, imagePullSecretName),
+                ]
+              : []),
           ])
 
             .then(() => {

frontend/src/pages/modelServing/screens/projects/ModelServingPlatform.tsx

@@ -36,6 +36,7 @@
 import { useIsNIMAvailable } from '~/pages/modelServing/screens/projects/useIsNIMAvailable';
 import { isProjectNIMSupported } from '~/pages/modelServing/screens/projects/nimUtils';
 import { useDashboardNamespace } from '~/redux/selectors';
+import DeployNIMServiceModal from '~/pages/modelServing/screens/projects/NIMServiceModal/DeployNIMServiceModal';
 import ManageServingRuntimeModal from './ServingRuntimeModal/ManageServingRuntimeModal';
 import ModelMeshServingRuntimeTable from './ModelMeshSection/ServingRuntimeTable';
 import ModelServingPlatformButtonAction from './ModelServingPlatformButtonAction';
@@ -275,6 +276,15 @@
           onSubmit(submit);
         }}
       />
+      {isNIMAvailable && (
+        <DeployNIMServiceModal
+          isOpen={platformSelected === ServingRuntimePlatform.SINGLE}
+          projectContext={{ currentProject, dataConnections }}
+          onClose={(submit: boolean) => {
+            onSubmit(submit);
+          }}
+        />
+      )}
     </>
   );
 };

frontend/src/pages/modelServing/screens/projects/NIMServiceModal/DeployNIMServiceModal.tsx

@@ -126,7 +126,7 @@
   const [actionInProgress, setActionInProgress] = React.useState(false);
   const [error, setError] = React.useState<Error | undefined>();
   const [alertVisible, setAlertVisible] = React.useState(true);
-  const [pvcSize, setPvcSize] = React.useState<string>('');
+  const [pvcSize, setPvcSize] = React.useState<string>('30Gi');
 
   React.useEffect(() => {
     if (currentProjectName && isOpen) {

frontend/src/pages/modelServing/screens/projects/NIMServiceModal/NIMModelListSection.tsx

@@ -85,6 +85,7 @@ const NIMModelListSection: React.FC<NIMModelListSectionProps> = ({
   return (
     <FormGroup label="NVIDIA NIM" fieldId="nim-model-list-selection" isRequired>
       <SimpleSelect
+        isScrollable
         isFullWidth
         isDisabled={isEditing || options.length === 0}
         id="nim-model-list-selection"

frontend/src/pages/modelServing/screens/projects/nimUtils.ts

@@ -22,13 +22,13 @@
       throw new Error(`Error fetching secret: ${response.statusText}`);
     }
     const secretData = await response.json();
-    return secretData;
+    return secretData.body;
   } catch (error) {
     throw new Error(`Failed to fetch secret: ${secretName}.`);
   }
 };
 export const getNIMData = async (isNGC: boolean): Promise<Record<string, string> | undefined> => {
-  const nimSecretData = isNGC
+  const nimSecretData: SecretKind = isNGC
     ? await getNIMSecretData(NIM_NGC_SECRET_NAME)
     : await getNIMSecretData(NIM_SECRET_NAME);
 

frontend/src/pages/projects/screens/detail/overview/serverModels/deployedModels/DeployedModelsSection.tsx

@@ -32,6 +32,7 @@ import AddModelFooter from '~/pages/projects/screens/detail/overview/serverModel
 import { InferenceServiceKind } from '~/k8sTypes';
 import { ProjectSectionID } from '~/pages/projects/screens/detail/types';
 import ModelServingContextProvider from '~/pages/modelServing/ModelServingContext';
+import { isProjectNIMSupported } from '~/pages/modelServing/screens/projects/nimUtils';
 import DeployedModelsCard from './DeployedModelsCard';
 
 interface DeployedModelsSectionProps {
@@ -53,6 +54,8 @@ const DeployedModelsSection: React.FC<DeployedModelsSectionProps> = ({ isMultiPl
   );
   const [deployedModels, setDeployedModels] = React.useState<InferenceServiceKind[]>([]);
 
+  const isKServeNIMEnabled = isProjectNIMSupported(currentProject);
+
   React.useEffect(() => {
     if (!inferenceServicesLoaded || !modelServersLoaded) {
       return;
@@ -176,7 +179,7 @@ const DeployedModelsSection: React.FC<DeployedModelsSectionProps> = ({ isMultiPl
               </TextContent>
             )}
           </CardBody>
-          {!platformError ? <AddModelFooter /> : null}
+          {!platformError ? <AddModelFooter isNIM={isKServeNIMEnabled} /> : null}
         </OverviewCard>
       );
     }