Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-13781] Storage classes grid not sorting by Display Name #3283

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Oct 1, 2024

https://issues.redhat.com/browse/RHOAIENG-13781

Description

Fixing sort that was previously using the storage class name instead of the storage class config display name.

Screen.Recording.2024-10-01.at.11.59.28.AM.mov

How Has This Been Tested?

Verify using storage class names that differ from their config display names that the Display name column sort is based on those displayName values versus the storage class name.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (228e221) to head (ea5aab4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/pages/storageClasses/constants.ts 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
- Coverage   84.87%   84.86%   -0.02%     
==========================================
  Files        1306     1306              
  Lines       29196    29201       +5     
  Branches     7885     7888       +3     
==========================================
+ Hits        24780    24781       +1     
- Misses       4416     4420       +4     
Files with missing lines Coverage Δ
frontend/src/pages/storageClasses/constants.ts 85.71% <83.33%> (-1.79%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228e221...ea5aab4. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 9372a8a into opendatahub-io:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants