Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHOAIENG-13781] Storage classes grid not sorting by Display Name #3283

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[RHOAIENG-13781] Storage classes grid not sorting by Display Name #3283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion frontend/src/pages/storageClasses/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@
{
field: 'displayName',
label: ColumnLabel.DisplayName,
sortable: (a, b) => a.metadata.name.localeCompare(b.metadata.name),
sortable: (a: StorageClassKind, b: StorageClassKind): number => {
const configDisplayNameA = getStorageClassConfig(a)?.displayName;
const configDisplayNameB = getStorageClassConfig(b)?.displayName;

if (configDisplayNameA && configDisplayNameB) {
return configDisplayNameA.localeCompare(configDisplayNameB);
}

return -1;

Check warning on line 25 in frontend/src/pages/storageClasses/constants.ts

View check run for this annotation

Codecov / codecov/patch

frontend/src/pages/storageClasses/constants.ts#L25 

Added line #L25 was not covered by tests
},
info: {
popoverProps: { headerContent: 'Display name' },
popover:
Expand Down
Loading