Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pvc fixes #3296

Merged
merged 2 commits into from
Oct 7, 2024

fix: pvc fixes based on feedback

3676b10
Select commit
Loading
Failed to load commit list.
Merged

fix: pvc fixes #3296

fix: pvc fixes based on feedback
3676b10
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 7, 2024 in 0s

75.86% of diff hit (target 70.00%)

View this Pull Request on Codecov

75.86% of diff hit (target 70.00%)

Annotations

Check warning on line 195 in frontend/src/pages/modelServing/screens/projects/NIMServiceModal/DeployNIMServiceModal.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

frontend/src/pages/modelServing/screens/projects/NIMServiceModal/DeployNIMServiceModal.tsx#L195

Added line #L195 was not covered by tests

Check warning on line 199 in frontend/src/pages/modelServing/screens/projects/NIMServiceModal/DeployNIMServiceModal.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

frontend/src/pages/modelServing/screens/projects/NIMServiceModal/DeployNIMServiceModal.tsx#L197-L199

Added lines #L197 - L199 were not covered by tests

Check warning on line 16 in frontend/src/pages/modelServing/screens/projects/nimUtils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

frontend/src/pages/modelServing/screens/projects/nimUtils.ts#L15-L16

Added lines #L15 - L16 were not covered by tests

Check warning on line 84 in frontend/src/pages/modelServing/screens/projects/nimUtils.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

frontend/src/pages/modelServing/screens/projects/nimUtils.ts#L84

Added line #L84 was not covered by tests