Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename visualization to artifact preview #3316

Closed
wants to merge 1 commit into from

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Oct 9, 2024

https://issues.redhat.com/browse/RHOAIENG-11413

Description

Alter artifact visualization to artifact preview

Screenshot 2024-10-09 at 6 05 09 PM

How Has This Been Tested?

  • Create a pipeline run having artifacts
  • Click on the artifact node and check whether the Visualization tab is renamed to Artifact preview

Test Impact

Updated the unit and cypress test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member

@pnaik1 I talked with @yannnz and this UX change is no longer wanted so i will close this PR.

/close

@openshift-ci openshift-ci bot closed this Oct 9, 2024
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

@Gkrumbach07: Closed this PR.

In response to this:

@pnaik1 I talked with @yannnz and this UX change is no longer wanted so i will close this PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants