Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename visualization to artifact preview #3316

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class ArtifactRightDrawer extends Contextual<HTMLDivElement> {
}

findVisualizationTab() {
return this.find().findByRole('tab', { name: 'Visualization' });
return this.find().findByRole('tab', { name: 'Artifact preview' });
}

findIframeContent() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ describe('Artifacts', () => {
);
});
});
describe('Pipeline run visualization tab', () => {
describe('Pipeline run Artifact preview tab', () => {
beforeEach(() => {
cy.interceptOdh(
'GET /api/service/pipelines/:namespace/:serviceName/apis/v2beta1/artifacts/:artifactId',
Expand All @@ -224,7 +224,7 @@ describe('Artifacts', () => {
initMlmdIntercepts(projectName);
});

it('check for visualization', () => {
it('check for Artifact preview', () => {
pipelineRunDetails.visit(
projectName,
mockPipeline.pipeline_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('PipelineRunDrawerRightContent', () => {

expect(tabs).toHaveLength(2);
expect(screen.getByRole('tab', { name: 'Artifact details' })).toBeVisible();
expect(screen.getByRole('tab', { name: 'Visualization' })).toBeVisible();
expect(screen.getByRole('tab', { name: 'Artifact preview' })).toBeVisible();
});

it('renders task drawer tabs when the task prop is of type "groupTask"', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type ArtifactNodeDrawerContentProps = Omit<

enum ArtifactNodeDrawerTab {
Details = 'details',
Visualization = 'visualization',
ArtifactPreview = 'artifactPreview',
}

export const ArtifactNodeDrawerContent: React.FC<ArtifactNodeDrawerContentProps> = ({
Expand Down Expand Up @@ -66,9 +66,9 @@ export const ArtifactNodeDrawerContent: React.FC<ArtifactNodeDrawerContentProps>
</Tab>
{isMetricsArtifactType(artifact.getType()) && (
<Tab
eventKey={ArtifactNodeDrawerTab.Visualization}
title={<TabTitleText>Visualization</TabTitleText>}
aria-label="Visualization"
eventKey={ArtifactNodeDrawerTab.ArtifactPreview}
title={<TabTitleText>Artifact preview</TabTitleText>}
aria-label="Artifact preview"
>
<ArtifactVisualization artifact={artifact} />
</Tab>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe('ArtifactNodeDrawerContent', () => {
),
);

await user.click(screen.getByRole('tab', { name: 'Visualization' }));
await user.click(screen.getByRole('tab', { name: 'Artifact preview' }));
expect(screen.getByRole('heading', { name: 'Scalar metrics' })).toBeVisible();
});

Expand Down Expand Up @@ -154,7 +154,7 @@ describe('ArtifactNodeDrawerContent', () => {
),
);

await user.click(screen.getByRole('tab', { name: 'Visualization' }));
await user.click(screen.getByRole('tab', { name: 'Artifact preview' }));
expect(screen.getByRole('heading', { name: 'ROC curve' })).toBeVisible();
});

Expand All @@ -179,7 +179,7 @@ describe('ArtifactNodeDrawerContent', () => {
</BrowserRouter>,
);

await user.click(screen.getByRole('tab', { name: 'Visualization' }));
await user.click(screen.getByRole('tab', { name: 'Artifact preview' }));
expect(screen.getByRole('heading', { name: 'Confusion matrix metrics' })).toBeVisible();
});

Expand All @@ -202,7 +202,7 @@ describe('ArtifactNodeDrawerContent', () => {
</BrowserRouter>,
);

expect(screen.queryByRole('tab', { name: 'Visualization' })).toBeNull();
expect(screen.queryByRole('tab', { name: 'Artifact preview' })).toBeNull();
});

it('should not render "Model" visualization drawer tab', async () => {
Expand All @@ -224,7 +224,7 @@ describe('ArtifactNodeDrawerContent', () => {
</BrowserRouter>,
);

expect(screen.queryByRole('tab', { name: 'Visualization' })).toBeNull();
expect(screen.queryByRole('tab', { name: 'Artifact preview' })).toBeNull();
});
});

Expand Down
Loading