Add P0 OOTB connection types

[jeff-phillips-18]

RHOAIENG-13105

Description

Adds yaml files for OOTB connection types. Updates the connection type page to not allow editing of the OOTB connection types. Fixes an issue where the connection types table does not update when new connections are added or modified.

How Has This Been Tested?

• Run the UI and navigate to Settings -> Connection types

• Install the connection types:

  • oc apply -f manifests/common/connection-types/s3.yaml
  • oc apply -f manifests/common/connection-types/oci-compliant-registry-v1.yaml
  • oc apply -f manifests/common/connection-types/uri-v1.yaml

• Verify the connection types are shown in the UI without needing to refresh the page within 30 seconds

• From the OpenShift Console, go to Administrator -> Home -> Search

  • Select the opendatahub project
  • Select Resource = OdhApplication
  • Find the jupyter OdhApplication and copy its ownerReference section of the Yaml file
  • Go back to the Search page and Select the ConfigMap Resource
  • Edit the s3, oci-compliant-registry-v1, and uri-v1 configmaps:
    • Add the copied ownerReference section to each of them
  • Check the UI and see that each now has Pre-installed for the creator column
  • Verify the Edit action in the kebab is disabled for each.

Test Impact

None, test already covered this functionality

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gkrumbach07 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (6ec1b1b) to head (2c0e398).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
- Coverage   84.79%   84.78%   -0.01%     
==========================================
  Files        1315     1315              
  Lines       29491    29492       +1     
  Branches     8056     8057       +1     
==========================================
- Hits        25006    25005       -1     
- Misses       4485     4487       +2     

Files with missing lines	Coverage Δ
.../pages/connectionTypes/ConnectionTypesTableRow.tsx	67.92% <ø> (ø)

... and 6 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec1b1b...2c0e398. Read the comment docs.

[christianvogt]

While the Edit action is disabled, i can select the duplicate action, then edit the URL from /duplicate/ to /edit/ and then I can save any changes. I believe the operator should just revert the change, however I don't think the user should be able to perform this action. The backend should prevent any request to update the preinstalled resources.

The delete action should not be enabled either. Should it be hidden? @simrandhaliw

Do we know if we should allow the admin to disable these connection types?

[christianvogt]

I don't believe we should include the namespace, creationTimestamp or username annotation.