Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add P0 OOTB connection types #3335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ const ConnectionTypesTableRow: React.FC<ConnectionTypesTableRowProps> = ({
{
title: 'Edit',
onClick: () => navigate(`/connectionTypes/edit/${obj.metadata.name}`),
isDisabled: ownedByDSC(obj),
},
{
title: 'Duplicate',
Expand Down
6 changes: 6 additions & 0 deletions manifests/common/connection-types/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ./oci-compliant-registry-v1.yaml
- ./s3.yaml
- ./uri-v1.yaml
17 changes: 17 additions & 0 deletions manifests/common/connection-types/oci-compliant-registry-v1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
kind: ConfigMap
apiVersion: v1
metadata:
name: oci-compliant-registry-v1
namespace: opendatahub
creationTimestamp: null
labels:
opendatahub.io/connection-type: 'true'
opendatahub.io/dashboard: 'true'
annotations:
opendatahub.io/enabled: 'true'
opendatahub.io/username: cluster-admin
Comment on lines +5 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we should include the namespace, creationTimestamp or username annotation.

openshift.io/description: 'Connect to an OCI-compliant container registry, enabling integration with containerized applications and services. Use this connection type to pull and manage container images and artifacts that adhere to the Open Container Initiative (OCI) standards, ensuring compatibility with OCI-compliant tools and workflows.'
openshift.io/display-name: OCI compliant registry - v1
data:
category: '["URI"]'
fields: '[{"type":"uri","name":"URI","envVar":"URI","required":true,"properties":{}}]'
17 changes: 17 additions & 0 deletions manifests/common/connection-types/s3.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
kind: ConfigMap
apiVersion: v1
metadata:
name: s3
namespace: opendatahub
creationTimestamp: null
labels:
opendatahub.io/connection-type: 'true'
opendatahub.io/dashboard: 'true'
annotations:
opendatahub.io/enabled: 'true'
opendatahub.io/username: cluster-admin
openshift.io/description: 'Connect to storage systems that are compatible with Amazon S3, enabling integration with other S3-compatible services and applications.'
openshift.io/display-name: S3 compatible object storage - v1
data:
category: '["Object storage"]'
fields: '[{"type":"short-text","name":"Access key","envVar":"AWS_ACCESS_KEY_ID","properties":{},"required":true},{"type":"hidden","name":"Secret key","envVar":"AWS_SECRET_ACCESS_KEY","required":true,"properties":{}},{"type":"short-text","name":"Endpoint","envVar":"AWS_S3_ENDPOINT","required":true,"properties":{}},{"type":"short-text","name":"Region","envVar":"AWS_DEFAULT_REGION","required":false,"properties":{}},{"type":"short-text","name":"Bucket","envVar":"AWS_S3_BUCKET","required":false,"properties":{}},{"type":"short-text","name":"Path","envVar":"AWS_S3_PATH","properties":{}}]'
17 changes: 17 additions & 0 deletions manifests/common/connection-types/uri-v1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
kind: ConfigMap
apiVersion: v1
metadata:
name: uri-v1
namespace: opendatahub
creationTimestamp: null
labels:
opendatahub.io/connection-type: 'true'
opendatahub.io/dashboard: 'true'
annotations:
opendatahub.io/enabled: 'true'
opendatahub.io/username: cluster-admin
openshift.io/description: Establish connections by using Uniform Resource Identifiers (URIs) to access various data sources.
openshift.io/display-name: URI - v1
data:
category: '["URI"]'
fields: '[{"type":"uri","name":"URI","envVar":"URI","required":true,"properties":{}}]'
1 change: 1 addition & 0 deletions manifests/common/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ kind: Kustomization
resources:
- ./crd
- ./apps
- ./connection-types