Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Gi/Mi size names to GiB/MiB #3338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename Gi/Mi size names to GiB/MiB #3338

wants to merge 1 commit into from
+21 −9

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Oct 15, 2024 •
edited
Loading

https://issues.redhat.com/browse/RHOAIENG-291

Description

Use GiB and MiB as the visual representation in the UI while keeping the current usage of Gi and Mi under the hood.

Before:
modal-before

Screenshot 2024-10-15 at 3 31 50 PM

After:
Screenshot 2024-10-15 at 3 44 39 PM

Screenshot 2024-10-15 at 4 21 03 PM

How Has This Been Tested?

Tested on Model Serving cluster.

  1. Create a DS project.
  2. Add a workbench.
  3. Go to the "Cluster Storage" tab in the selected DS project.
  4. Click "Add storage".
  5. Verify "Persistent Storage Size" units are GiB/MiB.
  6. For an existing cluster storage, go to kebab menu on table row.
  7. Click "Edit storage".
  8. Verify "Persistent Storage Size" units are GiB/MiB.
  9. Go to "Workbenches" in a Data Science Project.
  10. Expand a table row.
  11. Verify units shown in table are GiB/MiB.

Test Impact

Tests already exist, units have been updated.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jenny-s51
jenny-s51 commented Oct 15, 2024
View reviewed changes
Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on your suggestions @jeff-phillips-18 - would be great to get your thoughts on this approach as well @christianvogt.

@jenny-s51 jenny-s51 mentioned this pull request Oct 15, 2024
Closed
6 tasks
@jenny-s51
update memory units
6fd4c8c 
update tests

apply concatenation to units in workbenches table view

update parsing logic

fix TS errors

revert to text component to initial content formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jenny-s51