Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): set manifestUri as deprecated #1137

Open
wants to merge 1 commit into
base: incubation
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jul 24, 2024

  • we do not use this for devFlag in DSCI any more
  • it was used when we still have odh-manifests repo
  • if use would set devFlags, it should be done in DSC on component base
  • keep logic still in code but only set warning on API

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested review from lburgazzoli and VaishnaviHire and removed request for ajaypratap003 and gzaronikas July 24, 2024 10:24
@zdtsw zdtsw changed the title api: set manifestUri as deprecated docs(api): set manifestUri as deprecated Aug 22, 2024
@ykaliuta
Copy link
Contributor

looks good, but I'm not in the list of reviewers :)

@zdtsw
Copy link
Member Author

zdtsw commented Aug 22, 2024

looks good, but I'm not in the list of reviewers :)

thought i dont need bother you for the docs change :D

@openshift-ci openshift-ci bot added the lgtm label Oct 14, 2024
Copy link

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- we do not use this for devFlag in DSCI any more
- it was used when we still have odh-manifests repo
- if use would set devFlags, it should be done in DSC on component base
- keep logic still in code but only set warning on API

Signed-off-by: Wen Zhou <[email protected]>
Copy link

openshift-ci bot commented Oct 14, 2024

New changes are detected. LGTM label has been removed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (incubation@fa63b4d). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             incubation    #1137   +/-   ##
=============================================
  Coverage              ?   19.19%           
=============================================
  Files                 ?       30           
  Lines                 ?     2683           
  Branches              ?        0           
=============================================
  Hits                  ?      515           
  Misses                ?     2106           
  Partials              ?       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants