feat(taxonomy): implement TaxonomyCard component with competency and tags icons - #3226
feat(taxonomy): implement TaxonomyCard component with competency and tags icons#3226javoconsultant wants to merge 7 commits into
Conversation
…nomy type and remove unused styles
|
Thanks for the pull request, @javoconsultant! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
7df17d9 to
3e6d312
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3226 +/- ##
==========================================
+ Coverage 95.92% 95.93% +0.01%
==========================================
Files 1397 1409 +12
Lines 33581 33664 +83
Branches 7947 7956 +9
==========================================
+ Hits 32214 32297 +83
- Misses 1308 1309 +1
+ Partials 59 58 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3e6d312 to
5d2a0f1
Compare
Description
Supporting information
openedx/openedx-core#616
Testing instructions
- the target/competency icon for taxonomies of type Competency
- the tag icon for taxonomies of type Tags
- Click Import, upload a valid CSV/JSON file, and continue to the taxonomy details step.
- Confirm a Taxonomy Type dropdown is present with Tags (default) and Competency options.
- Select Competency, fill in name/description, and finish the import.
- Back on the taxonomy list, confirm the new card shows the competency icon.
- Repeat once more leaving Tags selected, and confirm that card shows the tag icon instead.
Other information
Dependencies:
#3208
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'