Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#36 update airflow #111

Merged
merged 104 commits into from
Aug 14, 2023
Merged

Features/#36 update airflow #111

merged 104 commits into from
Aug 14, 2023

Conversation

ClaraBuettner
Copy link

Fixes #36 .

ulfmueller and others added 30 commits June 28, 2023 14:14
@ClaraBuettner ClaraBuettner marked this pull request as ready for review July 18, 2023 07:10
Copy link

@CarlosEpia CarlosEpia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the installation in a new virtual environment, there were problems with the package psycopg2. Upgrading setuptools from 59.6.0 to 67.8.0 solved the problem. After this, the installation was successful.

When executing egon-data serve, the following problem was found:
AttributeError: module 'importlib_resources' has no attribute 'read_text'
This was solved by downgrading importlib-sources from 6.0.1 to 5.12.0.

Could be worth including a comment about the package docker-compose in the installation instructions: It must be installed using pip when it is not installed globally.

Comment on lines +820 to 827
if (
"eGon2035" in egon.data.config.settings()["egon-data"]["--scenarios"]
) and not (
"status2019" in egon.data.config.settings()["egon-data"]["--scenarios"]
):
tasks = tasks + (insert_data_nep,)

if "eGon100RE" in egon.data.config.settings()["egon-data"]["--scenarios"]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that for eGon100RE the task "insert_data_nep" should not be executed?

@ClaraBuettner
Copy link
Author

The problem with the username and password when opening the airflow web interface should be fixed now.

@CarlosEpia CarlosEpia self-requested a review August 11, 2023 10:37
Copy link

@CarlosEpia CarlosEpia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comments about dependencies are addressed, this PR can be merged.

@ClaraBuettner
Copy link
Author

Adding docker-compose to the install-requires resulted in problems with cdsapi. That is why I did not include it here.

@ClaraBuettner ClaraBuettner merged commit 5096b3f into dev Aug 14, 2023
4 checks passed
@ClaraBuettner ClaraBuettner deleted the features/#36-update-airflow branch October 18, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Apache Airflow version
3 participants