Skip to content

build: release v6.68.0 - #6571

Merged
foochifa merged 11 commits into
release-al2from
release_v6.68.0
Jul 27, 2023
Merged

build: release v6.68.0#6571
foochifa merged 11 commits into
release-al2from
release_v6.68.0

Conversation

@LinHuiqing

@LinHuiqing LinHuiqing commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

New

  • feat: rm bot protection for GSIB users #6568
  • chore: lint and update commands in README #6567
  • feat: MyInfo over sgID (frontend) #6447
  • chore: rm redundant type assertion in url validation #6566
  • feat: updated uen validator (ref stdnum) and tests cases #6534
  • fix: subtle bugs in MyInfo Child and UI copyedits #6562
  • feat: react router params validator for mongo ids #6561
  • build: merge v6.67.1 into develop #6559
  • build: release v6.67.1 #6557
  • fix: github warning about unused import #6558

Dependencies

Dev-Dependencies

  • chore(deps-dev): bump @types/lodash from 4.14.195 to 4.14.196 in /shared #6570

Tests

feat: rm bot protection for GSIB users #6568

@foochifa

  • Create a storage mode form with all fields
    • Make sure captcha is on
    • Go to the form on a device not on GSIB
      • Scroll to the bottom to check that captcha is there
      • Fill up and submit the form
      • Check that the response is recorded
    • Go to the form on a device on GSIB
      • Scroll to the bottom to check that captcha is not there
      • Fill up and submit the form
      • Check that the response is recorded
  • Create a email mode form with all fields
    • Make sure captcha is on
    • Go to the form on a device not on GSIB
      • Scroll to the bottom to check that captcha is there
      • Fill up and submit the form
      • Check that the response is recorded
    • Go to the form on a device on GSIB
      • Scroll to the bottom to check that captcha is not there
      • Fill up and submit the form
      • Check that the response is recorded

feat: MyInfo over sgID (frontend) #6447

@foochifa

  • Create an email mode form.
  • Go into settings page and click the new "Singpass App-only with MyInfo (Free)" radio button.
  • Drag and drop MyInfo fields into form.
  • Open the form to responses and share the form.
  • Authenticate with Singpass/Mockpass. Fields should automatically be filled up.

TODO

  • Test on real Singpass-MyInfo data (my own).

chore: rm redundant type assertion in url validation #6566

@foochifa
Regression test for webhook:

  • Create a storage mode form
  • Add a webhook to the form
  • Make a submission, it should successfully post a webhook as well.

feat: updated uen validator (ref stdnum) and tests cases #6534

@LinHuiqing

Test comprises 2 happy and 1 unhappy test cases. Happy test cases are based on UEN codes that are known to be valid issued by ACRA and Other entities. Unhappy test case checks if uen-validator captures the checksum accurately for all types if UEN. (5XXX, 2XXX, ROC, ROB, T and S entities.) See shared/utils/tests/uen-validation.spec.ts

May run as a check
npm run test:backend shared

Manual tests:

  • Create a email mode form with a UEN field
  • Submit the form with a local company UEN
  • Submit the form with a business UEN
  • Submit the form with a UEN from the others list
  • 3 emails should the received for the 3 successful form submissions above
  • Key in a UEN with the wrong checksum. The field should throw a warning.
  • Perform a submission through an API call with an invalid UEN. This should fail.

Deploy Notes

feat: react router params validator for mongo ids #6561

@kenjin-work

Check that the following dynamic routes should work when valid ids are given and redirect to a Not Found page when invalid ids are given:

  • Public routes
    • go to /:formId (public form page)
      • form should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /:formId/use-template (use template page)
      • use template page should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /:formId/payment/:paymentId (payment page)
      • payment page should render as usual
      • if :formId and/or :paymentId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /:formId/payment/:paymentId (payment page)
      • payment page should render as usual
      • if :formId and/or :paymentId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
  • Private routes
    • go to /admin/form/:formId (admin form page)
      • admin form create page should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /admin/form/:formId/settings (admin form settings page)
      • admin form settings page should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /admin/form/:formId/results (admin form results page)
      • admin form results page should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /admin/form/:formId/results/:submissionId (admin form results submission page)
      • admin form results submission page should render as usual
      • if :formId and/or :submissionId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /admin/form/:formId/results/feedback (admin form feedback page)
      • admin form feedback page should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /admin/form/:formId/preview (admin form preview page)
      • admin form preview page should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page
    • go to /admin/form/:formId/use-template (admin form use template page)
      • admin form use template page should render as usual
      • if :formId param is replaced with something outside of the regex /^([a-fA-F0-9]{24})$/, it should redirect to a not found page

kenjin-work and others added 11 commits July 20, 2023 17:16
build: merge v6.67.1 into develop
* feat: react router params validator for mongo ids

- refactor: rename FORMID_REGEX as MONGODB_ID_REGEX

* refactor: isInvalidMongoId check
* uen code

* first draft

* update

* feat. UEN validator added

* feat: updated uen validator based on stdnum, along with corresponding tests

* Update package.json

* refactored code for better readability

* updated code for better readibility and removed unnecessary updates

* ran prettier on uen-validation.ts and uen-validation.spec.ts

* revert package-lock.json

* deleted jest.config.js and.patch file

* removed jest (unnecessary) from shared/package.json

* updated UEN for e2e and frontend test, and ran linting on shared

* revert package.json and package-lock.json

* revert package-lock.json
* chore: rm redundant type assertion in url validation

- chore: remove unused isValidUrl function

* chore: backend linting

* chore: remove type assertion in useMdComponents

* chore: typo in comments
* feat: MyInfo over sgID (frontend)

* fix: address review

* feat: redesigned settings page

* feat: add tag, fix test

* fix: address Stacey's design review

* feat: aria-labels and fix test again

* fix: try to fix tests again

* fix: hopefully fix tests...

* fix: actually fix tests this time for real

* fix: disable children fields as well

* chore: revert back to original design

* chore: formatting

* chore: reduce diff

* fix: e2e tests

* fix: link to sgID data catalog

* fix: inline message

* fix: link

* fix: closer to Figma

* fix: even closer to Figma

* fix: design review addressed

* fix: UI review round 1.5

* fix: address all remaining design reviews

* fix: design add gap in initial sentence and first radio

* fix: address review by Huiqing

* fix: ensure same typography
* chore: lint and update commands in README

* nit: remove unused ignore

---------

Co-authored-by: LinHuiqing <huiqing@open.gov.sg>
* feat: rm bot protection against GSIB respondents

* fix: use enableCaptcha var

* fix: enableCaptcha conditional

* chore: move comment position
…red (#6570)

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.195 to 4.14.196.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

---
updated-dependencies:
- dependency-name: "@types/lodash"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@foochifa
foochifa merged commit 598a822 into release-al2 Jul 27, 2023
@foochifa
foochifa deleted the release_v6.68.0 branch July 27, 2023 03:49
@foochifa foochifa mentioned this pull request Aug 7, 2023
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants