build: release v6.69.0 - #6600
Merged
Merged
Conversation
build: merge v6.68.0 into develop
…shared (#6576) chore(deps-dev): bump eslint-config-prettier in /shared Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.8.0 to 8.9.0. - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v8.8.0...v8.9.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ref: remove download receipt URL * test: remove downloadPaymentReceipt test
…6580) Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.37 to 1.10.38. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.37...v1.10.38) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 3.13.0 to 4.1.0. - [Release notes](https://github.com/sindresorhus/type-fest/releases) - [Commits](sindresorhus/type-fest@v3.13.0...v4.1.0) --- updated-dependencies: - dependency-name: type-fest dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add helper text to variable payments field for min and max val * feat: update payment settings page copy * feat: misc copy changes * fix: increase spacing between 'Payments' header and first element * fix: update stripe onboarding guide link * feat: change description from textarea to input * fix: copy changes * feat: remove placeholder from business address and gst reg no inputs * feat: reorder payment item description * feat: change button copy for paynow option * fix: remove console.log * fix: remove unused import
* feat: add country field backend (#3770) * feat: add country field backend * fix: Fix Property 'country' is missing * fix: replace BasicField.Dropdown in CountryField story * fix: import CountryField into FieldFactory * fix: fix type errors due to lack of handling for new country field Co-authored-by: Kar Rui <karrui.lau@gmail.com> * feat: add CountryRegion field to frontend (#4112) * feat: add country field backend (#3770) * feat: add country field backend * fix: Fix Property 'country' is missing * fix: replace BasicField.Dropdown in CountryField story * fix: import CountryField into FieldFactory * fix: fix type errors due to lack of handling for new country field Co-authored-by: Kar Rui <karrui.lau@gmail.com> * feat: add Country field to frontend * feat: move Singapore up to the first value in the Country enum * test: add tests for CountryField * fix: update the typed characters in the partial typing test case * test: adjust test case for partial typing in Country field * refactor: rename Country enum to CountryRegion * refactor: rename BasicField.Country to BasicField.CountryRegion * refactor: rename CountryField to CountryRegionField * fix: commit renaming changes for tests/ * refactor: rename *Country* to *CountryRegion* in frontend edit field folder * feat: sort CountryRegion enums inside CountryRegionField * fix: remove removed isSaveEnabled prop * fix: inline sort country options constant * test: update CountryRegionField tests * fix(CountryRegionField): correctly set singapore as the first option also update tests to use the options that the field uses * style: use flag icon and fix capitalisation for CountryRegion * feat: allow validation rule overriding for DropdownField * fix: update error message for invalid Country/Region * test: fix country/region capitalisation in test Co-authored-by: Kar Rui <karrui.lau@gmail.com> * fix: remove duplicate country files * fix: remove duplicate country field files and restore TODO * chore: rename test file * fix: add missing imports * fix: use new CreatePageDrawerContentContainer component * fix: dropdown now uses requiredSingleAnswerValidationFn for validation * fix: add validation and processing of CountryRegion fields on client * refactor: implement specific CRField instead of using DropdownField * fix: remove unused field schema regression * feat: make CountryRegion values uppercase when sent to the server * Revert "feat: make CountryRegion values uppercase when sent to the server" This reverts commit be8a9d3. * fix: use title-case country/region only in render * Revert "fix: use title-case country/region only in render" This reverts commit 589af79. * feat: transform Country/Region form inputs to upper-case on submit * fix: validate against upper-case country/region, add comments on why this is done, and remove reference to any * fix: remove reference to toString() * fix: simulate transformations from handleSubmitForm in country-region-validation.spec.ts * fix: resolve rebase and use === instead of == * fix: remove duplicate import * chore: fix prettier violations * fix: update generate-form-data import path * fix: follow DropdownField's way of querying input element and casting options * fix: update INVALID_COUNTRY_REGION_OPTION_ERROR * fix: linting * fix: use uppercased countryregion for non-fetch submission --------- Co-authored-by: Kar Rui <karrui.lau@gmail.com> Co-authored-by: Jiayee Lim <jylim@indeed.com> Co-authored-by: Jiayee <jiayee@Jiayees-MacBook-Pro.local> Co-authored-by: tshuli <shuli@open.gov.sg>
* chore: remove unused toastr dep * docs: remove toastr package from credits
…/shared (#6593) chore(deps-dev): bump eslint-config-prettier in /shared Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.9.0 to 8.10.0. - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v8.9.0...v8.10.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: endpoint for pre-encrypt storage payload * refactor: extract receiver to separate module * refactor: use receiver middleware for email * doc: add comments to mark code for future removal * refactor: share isAttachmentResponse * doc: mark for future removal * fix: expected metadata * feat: add validateStorageSubmissionParams - refactor: clean up submission types naming * feat: check for newEncryptionBoundary flag * fix: comments from pairing with sebastian * fix: rm unnecessary undefined in filteredResponses * refactor: use getFilteredResponse - doc: remove reference implementation comments * fix: relative imports * refactor: move submission tests to right dir * refactor: mv submissions params overlap to constants * fix: use relative imports * test: handleDuplicatesInAttachments * fix: filesize limit based on submission type * test: add storage mode for createMultipartReceiver * fix: submission service test import * fix: validate submission params middleware - I was an idiot and replaced the params for the wrong middleware in d328c73 * fix: submission service relative imports * refactor: separate receiveSubmission middlewares
* feat: add notification flag to schema * feat: update types and update settings middleware * feat: FE integation to toggle issue notification * fix: integration issues and toast copy * feat: do not sent if notification flag is false * test: fix test cases * test: add test case to check that email is turned off * chore: remove redundant settings check
* updated payment view to follow colour theme * updated payment view to follow colour theme
wanlingt
approved these changes
Aug 7, 2023
This was referenced Aug 15, 2023
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
#6598#6590#6587#6589#5132#6581#6586#6577#6572#6571Dependencies
#6579#6580Dev-Dependencies
#6593#6576Tests
fix: updated payment view to follow colour theme
#6598@wanlingt
feat: toggle issue notification
#6590@wanlingt
test functionality
test regression
feat: BE endpoint to allow storage submissions before encryption
#6587@tshuli
To check that endpoint works:
/submissions/storage"version" : 1to bodyRegression tests:
chore: remove unused toastr dependency for snyk
#6589@foochifa
Regression tests:
feat: add Country/Region field
#5132@foochifa
Create email mode form with short text, country/region and country/region(optional) field.
Create storage mode form with short text, country/region and country/region(optional) field.
Create email mode form with all form fields. Check that submission works and input for non-country/region fields retain their casing
feat: payments UI/UX clean up
#6581@KenLSM