Skip to content

build: release v6.69.0 - #6600

Merged
foochifa merged 14 commits into
release-al2from
release_v6.69.0
Aug 7, 2023
Merged

build: release v6.69.0#6600
foochifa merged 14 commits into
release-al2from
release_v6.69.0

Conversation

@foochifa

@foochifa foochifa commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

New

  • fix: updated payment view to follow colour theme #6598
  • feat: toggle issue notification #6590
  • feat: BE endpoint to allow storage submissions before encryption #6587
  • chore: remove unused toastr dependency for snyk #6589
  • feat: add Country/Region field #5132
  • feat: payments UI/UX clean up #6581
  • feat: remove divider in payments input panel #6586
  • ref: remove download receipt URL #6577
  • build: merge v6.68.0 into develop #6572
  • build: release v6.68.0 #6571

Dependencies

  • fix(deps): bump type-fest from 3.13.0 to 4.1.0 in /shared #6579
  • fix(deps): bump libphonenumber-js from 1.10.37 to 1.10.38 in /shared #6580

Dev-Dependencies

  • chore(deps-dev): bump eslint-config-prettier from 8.9.0 to 8.10.0 in /shared #6593
  • chore(deps-dev): bump eslint-config-prettier from 8.8.0 to 8.9.0 in /shared #6576

Tests

fix: updated payment view to follow colour theme #6598

@wanlingt

  • Create a payment field
  • Select any colour theme aside from the default colour theme
  • Verify that colour theme changes accordingly in preview and actual form

feat: toggle issue notification #6590

@wanlingt
test functionality

  • Create a new form
  • Open form
  • Report issue, you should receive email notification
  • Create a new form
  • Toggle off notification on general settings page
  • Open form
  • Report issue, you shouldn't receive email notification
  • Check that issue is still in form->results->feedback

test regression

  • On an existing form without modifying general settings page
  • Open form
  • Report issue, you should receive email notification

feat: BE endpoint to allow storage submissions before encryption #6587

@tshuli

To check that endpoint works:

  • Create a email mode form switch off captcha.
  • Go to the respondent form and open the network tab before making a submission on the form.
  • Copy and save the corresponding curl request for the email submission made.
  • Duplicate the form to create the exact same form, but in storage mode. Make sure captcha is off.
  • Make the following edits to the curl request previously saved:
    • formId should be updated to the storage mode form's
    • update endpoint to be /submissions/storage
    • Add in "version" : 1 to body
  • Perform the curl request. The request should return an error saying "This endpoint has not been enabled for this form."
  • Go to the form's document on the DB and add a "newEncryptionBoundary" set to true.
  • Perform the curl request. Check for the following:
    • The response should say "Form submission successful."
    • The submission should show up in the form's results page.

Regression tests:

  • Submit a response on an email mode form. You should receive the corresponding email for the submission.
  • Submit a response on a storage mode form. You should see that the corresponding submission entry should show up on the admin results page.
  • Go to an email mode form's preview page. Make a submission. The app should not crash and you should receive a corresponding email for the submission.

chore: remove unused toastr dependency for snyk #6589

@foochifa

Regression tests:

  • Login as form admin.
  • Create a storage mode form.
    • Make a submission.
    • Check that submission recorded correctly.
  • Create an email mode form.
    • Make a submission.
    • Check that submission recorded correctly.

feat: add Country/Region field #5132

@foochifa

  • Create email mode form with short text, country/region and country/region(optional) field.

    • Form can be submitted with all fields filled in
      • Repeat using network call
    • Form can be submitted without optional field filled in
      • Repeat using network call
    • Form cannot be submitted with optional field filled in and non-optional country/region field not filled in
      • Repeat using network call
    • Cannot fill in invalid country on frontend
      • Sending invalid country via network call fails
      • Sending valid country but not in UPPERCASE via network call fails
  • Create storage mode form with short text, country/region and country/region(optional) field.

    • Form can be submitted with all fields filled in
      • Repeat using network call
    • Form can be submitted without optional field filled in
      • Repeat using network call
    • Form cannot be submitted with optional field filled in and non-optional country/region field not filled in
    • Cannot fill in invalid country on frontend
  • Create email mode form with all form fields. Check that submission works and input for non-country/region fields retain their casing

feat: payments UI/UX clean up #6581

@KenLSM

  • On a payment form's Stripe element, select PayNow. The button at the bottom of the form should say 'Scan PayNow QR code. Otherwise, it should say 'Submit payment'

LinHuiqing and others added 14 commits July 27, 2023 14:48
build: merge v6.68.0 into develop
…shared (#6576)

chore(deps-dev): bump eslint-config-prettier in /shared

Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.8.0 to 8.9.0.
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v8.8.0...v8.9.0)

---
updated-dependencies:
- dependency-name: eslint-config-prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ref: remove download receipt URL

* test: remove downloadPaymentReceipt test
…6580)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.37 to 1.10.38.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.37...v1.10.38)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 3.13.0 to 4.1.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v3.13.0...v4.1.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add helper text to variable payments field for min and max val

* feat: update payment settings page copy

* feat: misc copy changes

* fix: increase spacing between 'Payments' header and first element

* fix: update stripe onboarding guide link

* feat: change description from textarea to input

* fix: copy changes

* feat: remove placeholder from business address and gst reg no inputs

* feat: reorder payment item description

* feat: change button copy for paynow option

* fix: remove console.log

* fix: remove unused import
* feat: add country field backend (#3770)

* feat: add country field backend

* fix: Fix Property 'country' is missing

* fix: replace BasicField.Dropdown in CountryField story

* fix: import CountryField into FieldFactory

* fix: fix type errors due to lack of handling for new country field

Co-authored-by: Kar Rui <karrui.lau@gmail.com>

* feat: add CountryRegion field to frontend (#4112)

* feat: add country field backend (#3770)

* feat: add country field backend

* fix: Fix Property 'country' is missing

* fix: replace BasicField.Dropdown in CountryField story

* fix: import CountryField into FieldFactory

* fix: fix type errors due to lack of handling for new country field

Co-authored-by: Kar Rui <karrui.lau@gmail.com>

* feat: add Country field to frontend

* feat: move Singapore up to the first value in the Country enum

* test: add tests for CountryField

* fix: update the typed characters in the partial typing test case

* test: adjust test case for partial typing in Country field

* refactor: rename Country enum to CountryRegion

* refactor: rename BasicField.Country to BasicField.CountryRegion

* refactor: rename CountryField to CountryRegionField

* fix: commit renaming changes for tests/

* refactor: rename *Country* to *CountryRegion* in frontend edit field folder

* feat: sort CountryRegion enums inside CountryRegionField

* fix: remove removed isSaveEnabled prop

* fix: inline sort country options constant

* test: update CountryRegionField tests

* fix(CountryRegionField): correctly set singapore as the first option

also update tests to use the options that the field uses

* style: use flag icon and fix capitalisation for CountryRegion

* feat: allow validation rule overriding for DropdownField

* fix: update error message for invalid Country/Region

* test: fix country/region capitalisation in test

Co-authored-by: Kar Rui <karrui.lau@gmail.com>

* fix: remove duplicate country files

* fix: remove duplicate country field files and restore TODO

* chore: rename test file

* fix: add missing imports

* fix: use new CreatePageDrawerContentContainer component

* fix: dropdown now uses requiredSingleAnswerValidationFn for validation

* fix: add validation and processing of CountryRegion fields on client

* refactor: implement specific CRField instead of using DropdownField

* fix: remove unused field schema regression

* feat: make CountryRegion values uppercase when sent to the server

* Revert "feat: make CountryRegion values uppercase when sent to the server"

This reverts commit be8a9d3.

* fix: use title-case country/region only in render

* Revert "fix: use title-case country/region only in render"

This reverts commit 589af79.

* feat: transform Country/Region form inputs to upper-case on submit

* fix: validate against upper-case country/region, add comments on why this is done, and remove reference to any

* fix: remove reference to toString()

* fix: simulate transformations from handleSubmitForm in country-region-validation.spec.ts

* fix: resolve rebase and use === instead of ==

* fix: remove duplicate import

* chore: fix prettier violations

* fix: update generate-form-data import path

* fix: follow DropdownField's way of querying input element and casting options

* fix: update INVALID_COUNTRY_REGION_OPTION_ERROR

* fix: linting

* fix: use uppercased countryregion for non-fetch submission

---------

Co-authored-by: Kar Rui <karrui.lau@gmail.com>
Co-authored-by: Jiayee Lim <jylim@indeed.com>
Co-authored-by: Jiayee <jiayee@Jiayees-MacBook-Pro.local>
Co-authored-by: tshuli <shuli@open.gov.sg>
* chore: remove unused toastr dep

* docs: remove toastr package from credits
…/shared (#6593)

chore(deps-dev): bump eslint-config-prettier in /shared

Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.9.0 to 8.10.0.
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v8.9.0...v8.10.0)

---
updated-dependencies:
- dependency-name: eslint-config-prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: endpoint for pre-encrypt storage payload

* refactor: extract receiver to separate module

* refactor: use receiver middleware for email

* doc: add comments to mark code for future removal

* refactor: share isAttachmentResponse

* doc: mark for future removal

* fix: expected metadata

* feat: add validateStorageSubmissionParams

- refactor: clean up submission types naming

* feat: check for newEncryptionBoundary flag

* fix: comments from pairing with sebastian

* fix: rm unnecessary undefined in filteredResponses

* refactor: use getFilteredResponse

- doc: remove reference implementation comments

* fix: relative imports

* refactor: move submission tests to right dir

* refactor: mv submissions params overlap to constants

* fix: use relative imports

* test: handleDuplicatesInAttachments

* fix: filesize limit based on submission type

* test: add storage mode for createMultipartReceiver

* fix: submission service test import

* fix: validate submission params middleware

- I was an idiot and replaced the params for the wrong middleware in d328c73

* fix: submission service relative imports

* refactor: separate receiveSubmission middlewares
* feat: add notification flag to schema

* feat: update types and update settings middleware

* feat: FE integation to toggle issue notification

* fix: integration issues and toast copy

* feat: do not sent if notification flag is false

* test: fix test cases

* test: add test case to check that email is turned off

* chore: remove redundant settings check
* updated payment view to follow colour theme

* updated payment view to follow colour theme
@foochifa
foochifa merged commit 9a4ae0d into release-al2 Aug 7, 2023
@foochifa
foochifa deleted the release_v6.69.0 branch August 7, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants