8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631

[dholmes-ora]

I missed that the UserHandler can still be used even if -Xrs is specified, so we have to check for !ReduceSignalUsage as per Kim's initial suggestion in JDK-8369631.

Testing

• tiers 1-4

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631 (Bug - P3)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27888/head:pull/27888
$ git checkout pull/27888

Update a local copy of the PR:
$ git checkout pull/27888
$ git pull https://git.openjdk.org/jdk.git pull/27888/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27888

View PR using the GUI difftool:
$ git pr show -t 27888

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27888.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631

Reviewed-by: kbarrett, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 43e036b: 8366424: Missing type profiling in generated Record Object methods
• b68fa43: Merge
• e1d1fa9: 8360937: Enhance certificate handling
• ... and 34 more: https://git.openjdk.org/jdk/compare/2148dbbe75bb827d568532021391beb0738744c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9a69dd1e)
• 00: Full (ed3227a7)

[kimbarrett]

Looks good.

[dholmes-ora]

Thanks for the review @kimbarrett !

[coleenp]

Looks good.

[coleenp]

So this makes sense because the old code did get there:
680414d#diff-810ea508a8b69c83a17b3f641ac67d9b571324e0a7d66426e4a18580413b3d9aL172-L361

[dholmes-ora]

Thanks for the review @coleenp !

/integrate

[openjdk]

Going to push as commit aab3fc5.
Since your change was applied there have been 37 commits pushed to the master branch:

• 43e036b: 8366424: Missing type profiling in generated Record Object methods
• b68fa43: Merge
• e1d1fa9: 8360937: Enhance certificate handling
• ... and 34 more: https://git.openjdk.org/jdk/compare/2148dbbe75bb827d568532021391beb0738744c2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit aab3fc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.