Skip to content

8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631 #27888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631 #27888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed3227a
8370207: Test sun/misc/SunMiscSignalTest.java crashes after JDK-8369631
dholmes-ora Oct 20, 2025
283722b
Merge branch 'master' into 8370207-sem_notify-crash
dholmes-ora Oct 20, 2025
9a69dd1
Un-ProblemList the test
dholmes-ora Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hotspot/os/posix/signals_posix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,12 @@ static void jdk_misc_signal_init() {
}

void os::signal_notify(int sig) {
// Signal thread is not created with ReduceSignalUsage and jdk_misc_signal_init
// initialization isn't called. This code is also never called.
assert(!ReduceSignalUsage, "Should not reach here if ReduceSignalUsage is set");

// Signal thread is not created with ReduceSignalUsage and jdk_misc_signal_init
// initialization isn't called.
if (!ReduceSignalUsage) {
AtomicAccess::inc(&pending_signals[sig]);
sig_semaphore->signal();
}
Copy link
Contributor

@coleenp coleenp Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this makes sense because the old code did get there:
680414d#diff-810ea508a8b69c83a17b3f641ac67d9b571324e0a7d66426e4a18580413b3d9aL172-L361

}

static int check_pending_signals() {
Expand Down
2 changes: 0 additions & 2 deletions test/jdk/ProblemList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,8 +743,6 @@ sun/tools/jstatd/TestJstatdRmiPort.java 8251259,8293577
jdk/incubator/vector/ShortMaxVectorTests.java 8306592 generic-i586
jdk/incubator/vector/LoadJsvmlTest.java 8305390 windows-x64

sun/misc/SunMiscSignalTest.java 8370207 generic-all

############################################################################

# jdk_jfr
Expand Down