Skip to content

Conversation

dbriemann
Copy link
Member

@dbriemann dbriemann commented Oct 20, 2025

This is a port of 8369505 for PPC. It allows to calculate caller SP from CodeBlob for continuation stub.
It also enables the test test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackWithVirtualThread.java for PPC.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370240: [PPC64] jhsdb jstack cannot handle continuation stub (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27902/head:pull/27902
$ git checkout pull/27902

Update a local copy of the PR:
$ git checkout pull/27902
$ git pull https://git.openjdk.org/jdk.git pull/27902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27902

View PR using the GUI difftool:
$ git pr show -t 27902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27902.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2025

👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@dbriemann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370240: [PPC64] jhsdb jstack cannot handle continuation stub

Reviewed-by: mdoerr, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 20, 2025

@dbriemann The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2025

Webrevs

* @bug 8369505
* @requires vm.hasSA
* @requires (os.arch == "amd64" | os.arch == "x86_64" | os.arch == "aarch64" | os.arch == "riscv64")
* @requires (os.arch == "amd64" | os.arch == "x86_64" | os.arch == "aarch64" | os.arch == "riscv64" | os.arch == "ppc64" | os.arch == "ppc64le")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still an arch that is unsupported? Otherwise the whole line can be dropped, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2025
Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Cheers, Richard.

@dbriemann
Copy link
Member Author

Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

Going to push as commit d4c0239.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2025
@openjdk openjdk bot closed this Oct 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@dbriemann Pushed as commit d4c0239.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dbriemann dbriemann deleted the dlb/jhsdb_stack branch October 22, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability [email protected]

Development

Successfully merging this pull request may close these issues.

4 participants