Skip to content

8370240: [PPC64] jhsdb jstack cannot handle continuation stub #27902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8370240: [PPC64] jhsdb jstack cannot handle continuation stub #27902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aedfd5
8370240: [PPC64] jhsdb jstack cannot handle continuation stub
dbriemann Oct 20, 2025
056a8b5
remove unnecessary requires
dbriemann Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ppc64/PPC64Frame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,13 @@ public Frame sender(RegisterMap regMap, CodeBlob cb) {
}

if (cb != null) {
return cb.isUpcallStub() ? senderForUpcallStub(map, (UpcallStub)cb) : senderForCompiledFrame(map, cb);
if (cb.isUpcallStub()) {
return senderForUpcallStub(map, (UpcallStub)cb);
} else if (cb.isContinuationStub()) {
return senderForContinuationStub(map, cb);
} else {
return senderForCompiledFrame(map, cb);
}
}

// Must be native-compiled frame, i.e. the marshaling code for native
Expand Down Expand Up @@ -331,6 +337,15 @@ private Frame senderForInterpreterFrame(PPC64RegisterMap map) {
return new PPC64Frame(sp, unextendedSP, getLink(), getSenderPC());
}

private Frame senderForContinuationStub(PPC64RegisterMap map, CodeBlob cb) {
var contEntry = map.getThread().getContEntry();

Address sp = contEntry.getEntrySP();
Address pc = contEntry.getEntryPC();
Address fp = contEntry.getEntryFP();

return new PPC64Frame(sp, fp, pc);
}

private Frame senderForCompiledFrame(PPC64RegisterMap map, CodeBlob cb) {
if (DEBUG) {
Expand Down
2 changes: 1 addition & 1 deletion test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackWithVirtualThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* @test
* @bug 8369505
* @requires vm.hasSA
* @requires (os.arch == "amd64" | os.arch == "x86_64" | os.arch == "aarch64" | os.arch == "riscv64")
* @requires (os.arch == "amd64" | os.arch == "x86_64" | os.arch == "aarch64" | os.arch == "riscv64" | os.arch == "ppc64" | os.arch == "ppc64le")
Copy link
Contributor

@RealCLanger RealCLanger Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still an arch that is unsupported? Otherwise the whole line can be dropped, no?

Copy link
Member

@reinrich reinrich Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed.

* @library /test/lib
* @run driver TestJhsdbJstackWithVirtualThread
*/
Expand Down