-
Notifications
You must be signed in to change notification settings - Fork 26
8370572: Cgroups hierarchical memory limit is not honored after JDK-8322420 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
@jerboaa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
GHA failure of |
|
|
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I do have a comment:
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you!
|
Thanks for the review! |
|
/integrate |
|
Going to push as commit 5a08f94.
Your commit was automatically rebased without conflicts. |
Unclean backport of JDK-8370572 since JDK-8292984 is not in 25u (a cleanup patch). That change basically renames
phys_memtoupper_bound. Not really critical to get JDK-8292984 into 25u.Please review!
Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/76/head:pull/76$ git checkout pull/76Update a local copy of the PR:
$ git checkout pull/76$ git pull https://git.openjdk.org/jdk25u-dev.git pull/76/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 76View PR using the GUI difftool:
$ git pr show -t 76Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/76.diff
Using Webrev
Link to Webrev Comment