Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 11, 2025

Clean backport of the test for #76


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370966 needs maintainer approval

Issue

  • JDK-8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/77.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/76 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 291003208c025ce4f9a94ba6093e207d0792bbb9 8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572 Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Dec 11, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 12, 2025
@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 16, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/76 to master December 19, 2025 09:33
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk-8370966-test-backport
git fetch https://git.openjdk.org/jdk25u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

⚠️ @jerboaa This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Dec 19, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 19, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

Going to push as commit c3eecc0.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2025
@openjdk openjdk bot closed this Dec 19, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 19, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@jerboaa Pushed as commit c3eecc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant