Skip to content

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Aug 21, 2025

I'd like to backport it for parity with Oracle 8u.
11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md.

GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8303482 needs maintainer approval

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/678/head:pull/678
$ git checkout pull/678

Update a local copy of the PR:
$ git checkout pull/678
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 678

View PR using the GUI difftool:
$ git pr show -t 678

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/678.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2025

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into pr/677 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e28b210d5020fc7cc3a52c58f0a8ce14e16dd5fb 8303482: Update LCMS to 2.15 Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 21, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2025

Webrevs

@openjdk openjdk bot mentioned this pull request Aug 22, 2025
4 tasks
@kvergizova
Copy link
Contributor Author

Additional testing: java/awt/color/* and sun/java2d/cmm/* tests passed successfully

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/677 to master September 17, 2025 20:55
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8303482
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

@kvergizova Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant