-
Notifications
You must be signed in to change notification settings - Fork 171
8303482: Update LCMS to 2.15 #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Additional testing: java/awt/color/* and sun/java2d/cmm/* tests passed successfully |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8303482
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@kvergizova Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
I'd like to backport it for parity with Oracle 8u.
11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md.
GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/678/head:pull/678
$ git checkout pull/678
Update a local copy of the PR:
$ git checkout pull/678
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/678/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 678
View PR using the GUI difftool:
$ git pr show -t 678
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/678.diff
Using Webrev
Link to Webrev Comment