Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devex #147

Merged
merged 46 commits into from
Dec 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
7c58504
Migrate to `review_records` from `review_row`
jthompson-arcus Nov 13, 2024
b271add
Update test-fct_SQLite.R
jthompson-arcus Nov 13, 2024
39d8da1
Update test-mod_review_forms.R
jthompson-arcus Nov 13, 2024
43931ed
Update test-mod_main_sidebar.R
jthompson-arcus Nov 13, 2024
d311ab1
Fix R CMD checks
jthompson-arcus Nov 13, 2024
ccd9bb1
Fix `db_get_review()` example
jthompson-arcus Nov 13, 2024
0743880
Helps if you update documentation
jthompson-arcus Nov 13, 2024
e5e8acb
Only UPDATE reviews when review status is changed
jthompson-arcus Nov 14, 2024
2551970
Resolve merge conflicts with `jt-113-simplify_review_process`
jthompson-arcus Nov 19, 2024
d863300
Keep current structure for enabling reviews
jthompson-arcus Nov 19, 2024
6ad27a6
Resolve merge conflict with `dev`
jthompson-arcus Nov 20, 2024
a23b462
Generalize `db_get_review()`
jthompson-arcus Nov 20, 2024
6990cf1
Update version and NEWS
jthompson-arcus Nov 20, 2024
3db4274
Update scenario description for two rows
jthompson-arcus Nov 21, 2024
1c675a9
Update language from row to records
jthompson-arcus Nov 21, 2024
c177a30
Grab un-duplicated `rv_records`
jthompson-arcus Nov 21, 2024
d2fa0d6
Remove unnecessary `dplyr::select()`
jthompson-arcus Nov 21, 2024
de24777
Remove unneeded `dplyr::distinct()`
jthompson-arcus Nov 21, 2024
d372afa
Return `db_get_review()` when `...` is empty
jthompson-arcus Nov 21, 2024
8261441
Update to latest test-coverage. Remove package installation since it …
LDSamson Nov 19, 2024
0f4a693
Fix codecov arguments for codecov-actvion V5 https://github.com/marke…
LDSamson Nov 21, 2024
c547862
Print codecov results again
LDSamson Nov 21, 2024
f28f174
Update test-mod_review_forms.R
jthompson-arcus Nov 21, 2024
047b459
Update version and news
LDSamson Nov 21, 2024
7e26f83
Update only one table in `db_save_review()`
jthompson-arcus Nov 21, 2024
ad3f05e
Fix oopsies
jthompson-arcus Nov 21, 2024
b2bd9bb
Merge pull request #139 from openpharma/ls_update_codecov
jthompson-arcus Nov 21, 2024
939566f
Fix merge conflict with `dev`
jthompson-arcus Nov 21, 2024
439d14b
Add test for `db_get_review()` when no filters are specified
jthompson-arcus Nov 22, 2024
0079348
Fix `updated_items_memory`
jthompson-arcus Nov 22, 2024
ca83997
Don't export db_get_review anymore
LDSamson Nov 28, 2024
0f680cd
Update documentation
LDSamson Nov 28, 2024
a08c510
Ensure db_get_review errors before sending a db query if `...` cannot…
LDSamson Nov 28, 2024
f7ba04a
Add additional tests
LDSamson Nov 28, 2024
205896f
Use more consistent naming in the save review process
LDSamson Nov 28, 2024
b8f3f52
Change a dplyr::filter call to base R filter for performance reasons
LDSamson Nov 28, 2024
0154355
Ensure that updated_records_memory has the same columns as in the db
LDSamson Nov 28, 2024
f0144a2
Ensure tests will fail if there is a review discrepancy
LDSamson Nov 28, 2024
5360760
Export review_save_error to ensure errors are captured when saving re…
LDSamson Nov 28, 2024
88f5b04
Update snaps
LDSamson Nov 28, 2024
23b6e91
Also update mod_main_sidebar snaps
LDSamson Nov 28, 2024
6ce5827
Change to base R filter
LDSamson Dec 2, 2024
0e8ecc7
Fix review saving by selecting correct rows to update within the appl…
LDSamson Dec 2, 2024
d8e24d4
Remove the (now) redundant filtering by timestamp for updated_records…
LDSamson Dec 2, 2024
5845568
Merge pull request #137 from openpharma/jt-99-review_by_row
LDSamson Dec 2, 2024
05a3ee4
Resolve merge conflicts with `dev`
jthompson-arcus Dec 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update snaps
LDSamson committed Nov 28, 2024
commit 88f5b0410f976b1b878d521d869ac3f9b524b3ca
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/mod_review_forms.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# mod_review_forms. Feature 2 | Save review of a form. As a user, I want to be able to save a review of a form in the database. After saving the review, all items of that form that are not yet reviewed should get a tag that the value was reviewed.: Scenario 1 - Save a review. Given test review data with at least an 'Adverse event' form with patient '885',and [user_name] set to 'test_name' and [user_role] to 'Medical Monitor'and [active_patient] set to '885', and [active_form] set to 'Adverse events', and [active_tab] set to 'Common forms', and [form_reviewed] set to FALSE, I expect that I can save a new review properly, with the result saved in the application being the same as the one saved in the database.
# mod_review_forms. Feature 2 | Save review of a form. As a user, I want to be able to save a review of a form in the database. After saving the review, all items of that form that are not yet reviewed should get a tag that the value was reviewed.: Scenario 1 - Save a review. Given test review data with at least an 'Adverse event' form with patient '885',and [user_name] set to 'test_name' and [user_role] to 'Medical Monitor'and [active_patient] set to '885', and [active_form] set to 'Adverse events', and [active_tab] set to 'Common forms', and [form_reviewed] set to FALSE, I expect that I can save a new review properly, with the result saved in the application being the same as the one saved in the database, and no review error occurring

Code
dplyr::select(r$review_data, -timestamp)
Original file line number Diff line number Diff line change
@@ -17,6 +17,6 @@
}
},
"export": {

"test-review_save_error": false
}
}
Original file line number Diff line number Diff line change
@@ -10,6 +10,6 @@
"test-save_review_error": ""
},
"export": {

"test-review_save_error": false
}
}
Original file line number Diff line number Diff line change
@@ -17,6 +17,6 @@
}
},
"export": {

"test-review_save_error": false
}
}
Original file line number Diff line number Diff line change
@@ -17,6 +17,6 @@
}
},
"export": {

"test-review_save_error": false
}
}