[Backport 2.x] Add SortResponseProcessor to Search Pipelines (#14785) #14868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SortResponseProcessor for search pipelines Signed-off-by: Daniel Widdis <[email protected]> * Add stupid and unnecessary javadocs to satisfy overly strict CI Signed-off-by: Daniel Widdis <[email protected]> * Split casting and sorting methods for readability Signed-off-by: Daniel Widdis <[email protected]> * Register the sort processor factory Signed-off-by: Daniel Widdis <[email protected]> * Address code review comments Signed-off-by: Daniel Widdis <[email protected]> * Cast individual list elements to avoid creating two lists Signed-off-by: Daniel Widdis <[email protected]> * Add yamlRestTests Signed-off-by: Daniel Widdis <[email protected]> * Clarify why there's unusual sorting Signed-off-by: Daniel Widdis <[email protected]> * Use instanceof instead of isAssignableFrom Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
owaiskazi19
approved these changes
Jul 22, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/backport-2.16
# Create a new branch
git switch --create backport/backport-14868-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 10bdfeecb978c06c059304a12187a696abc940b4
# Push it to GitHub
git push --set-upstream origin backport/backport-14868-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.16Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Add SortResponseProcessor for search pipelines * Add stupid and unnecessary javadocs to satisfy overly strict CI * Split casting and sorting methods for readability * Register the sort processor factory * Address code review comments * Cast individual list elements to avoid creating two lists * Add yamlRestTests * Clarify why there's unusual sorting * Use instanceof instead of isAssignableFrom --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 10bdfee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged the conflicting PR and toggled the backport 2.16 label, it auto-generated. No further action needed. |
dbwiddis
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Add SortResponseProcessor for search pipelines * Add stupid and unnecessary javadocs to satisfy overly strict CI * Split casting and sorting methods for readability * Register the sort processor factory * Address code review comments * Cast individual list elements to avoid creating two lists * Add yamlRestTests * Clarify why there's unusual sorting * Use instanceof instead of isAssignableFrom --------- (cherry picked from commit 10bdfee) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…) (opensearch-project#14868) * Add SortResponseProcessor for search pipelines * Add stupid and unnecessary javadocs to satisfy overly strict CI * Split casting and sorting methods for readability * Register the sort processor factory * Address code review comments * Cast individual list elements to avoid creating two lists * Add yamlRestTests * Clarify why there's unusual sorting * Use instanceof instead of isAssignableFrom --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: kkewwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5de0c8a from #14785.