Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: change parent item name #234

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 12, 2024

Description

image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yuye-aws
Copy link
Member

@SuZhou-Joe
Copy link
Member Author

SuZhou-Joe commented Aug 13, 2024

Will take a look.

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AWSHurneyt AWSHurneyt merged commit 562d3a1 into opensearch-project:main Aug 13, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 13, 2024
* feat: change parent item name

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update title of entries

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update link

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add description

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 562d3a1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 14, 2024
* feat: change parent item name



* feat: update title of entries



* feat: update link



* feat: add description



---------


(cherry picked from commit 562d3a1)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants