Fix build errors after refactoring of Strings class in core #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws and
gaobinlong
as code owners
xluo-aws
approved these changes
May 22, 2023
|
test run on
|
gaobinlong
approved these changes
May 23, 2023
petardz
pushed a commit
to petardz/index-management
that referenced
this pull request
May 31, 2023
…ch-project#786) Signed-off-by: Hailong Cui <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-786-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 30e16d999d18e0001c8963794f8fcef5eb3c6e80
# Push it to GitHub
git push --set-upstream origin backport/backport-786-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Hailong-am
added a commit
to Hailong-am/index-management
that referenced
this pull request
Jul 7, 2023
…ch-project#786) (cherry picked from commit 30e16d9) Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
added a commit
to Hailong-am/index-management
that referenced
this pull request
Jul 7, 2023
…ch-project#786) (cherry picked from commit 30e16d9) Signed-off-by: Hailong Cui <[email protected]>
xluo-aws
pushed a commit
that referenced
this pull request
Jul 10, 2023
) (cherry picked from commit 30e16d9) Signed-off-by: Hailong Cui <[email protected]>
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
…ch-project#786) (opensearch-project#845) (cherry picked from commit 30e16d9) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix build errors after refactoring of Strings class in core
opensearch-project/OpenSearch#7508
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.