-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x]Fix build errors after refactoring of Strings class in core (#786) #845
Merged
xluo-aws
merged 2 commits into
opensearch-project:2.x
from
Hailong-am:backport/backport-786-to-2.x
Jul 10, 2023
Merged
[Backport 2.x]Fix build errors after refactoring of Strings class in core (#786) #845
xluo-aws
merged 2 commits into
opensearch-project:2.x
from
Hailong-am:backport/backport-786-to-2.x
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-project#786) (cherry picked from commit 30e16d9) Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
amsiglan,
sbcd90,
eirsep and
AWSHurneyt
as code owners
July 7, 2023 07:08
1 task
gaobinlong
approved these changes
Jul 7, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #845 +/- ##
============================================
- Coverage 75.72% 75.66% -0.07%
+ Complexity 2885 2881 -4
============================================
Files 366 366
Lines 16558 16558
Branches 2397 2397
============================================
- Hits 12539 12529 -10
- Misses 2640 2646 +6
- Partials 1379 1383 +4
|
security test failed due to OpenSearchSecurityPlugin is not latest
|
xluo-aws
approved these changes
Jul 10, 2023
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
…ch-project#786) (opensearch-project#845) (cherry picked from commit 30e16d9) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 30e16d9 from #786