Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x]Fix build errors after refactoring of Strings class in core (#786) #845

Merged

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Jul 7, 2023

Backport 30e16d9 from #786

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #845 (dba0f5f) into 2.x (344839a) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #845      +/-   ##
============================================
- Coverage     75.72%   75.66%   -0.07%     
+ Complexity     2885     2881       -4     
============================================
  Files           366      366              
  Lines         16558    16558              
  Branches       2397     2397              
============================================
- Hits          12539    12529      -10     
- Misses         2640     2646       +6     
- Partials       1379     1383       +4     
Impacted Files Coverage Δ
...nt/indexstatemanagement/model/destination/Chime.kt 55.55% <ø> (ø)
...statemanagement/model/destination/CustomWebhook.kt 68.57% <ø> (ø)
...nt/indexstatemanagement/model/destination/Slack.kt 77.77% <ø> (ø)
...statemanagement/resthandler/RestAddPolicyAction.kt 80.95% <ø> (ø)
...temanagement/resthandler/RestChangePolicyAction.kt 95.00% <ø> (ø)
...exstatemanagement/resthandler/RestExplainAction.kt 100.00% <ø> (ø)
...temanagement/resthandler/RestRemovePolicyAction.kt 100.00% <ø> (ø)
...t/resthandler/RestRetryFailedManagedIndexAction.kt 88.00% <ø> (ø)
...refreshanalyzer/RestRefreshSearchAnalyzerAction.kt 94.11% <ø> (ø)
...ment/rollup/resthandler/RestExplainRollupAction.kt 100.00% <ø> (ø)
... and 3 more

... and 12 files with indirect coverage changes

@Hailong-am
Copy link
Collaborator Author

Hailong-am commented Jul 10, 2023

security test failed due to OpenSearchSecurityPlugin is not latest

java.lang.NoClassDefFoundError: org/opensearch/core/common/io/stream/BaseStreamInput
»  	at org.opensearch.security.action.configupdate.ConfigUpdateAction.<init>(ConfigUpdateAction.java:37)
»  	at org.opensearch.security.action.configupdate.ConfigUpdateAction.<clinit>(ConfigUpdateAction.java:33)
»  	at org.opensearch.security.OpenSearchSecurityPlugin.getActions(OpenSearchSecurityPlugin.java:570)
»  	at org.opensearch.action.ActionModule.lambda$setupActions$3(ActionModule.java:714)
»  	at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:27

@xluo-aws xluo-aws merged commit ccd01b1 into opensearch-project:2.x Jul 10, 2023
12 of 14 checks passed
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants