Constants added for searchbackpressure rca reader to consume searchbackpressure metrics in shared folder #34
Conversation
…off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]>
CoderJeffrey
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
| // Table Name stored in sqlitedb | ||
| public static final String SEARCHBP_TABLE_NAME = "Searchbp_Stats"; | ||
| // Column Names for difference stats stored in sqlitedb | ||
| public static final String SEARCHBP_TYPE_DIM = "SearchBackPressureStats"; |
There was a problem hiding this comment.
Can we add some details about the purpose of this ?
There was a problem hiding this comment.
Resolved in latest commit.
Also paste here for better visibility.
Add SEARCHBP_TABLE_NAME for searchbackpressureRCA to find the corresponding table
Add SEARCHBP_TYPE_DIM for searchbackpressureRCA to find the cell value for each stats type
There was a problem hiding this comment.
@CoderJeffrey can you plz add comments for 2 constants separately?
e.g.
/**
* Add SEARCHBP_TABLE_NAME for searchbackpressureRCA to find the corresponding table
*/
public static final String SEARCHBP_TABLE_NAME = "Searchbp_Stats";
/**
* Add SEARCHBP_TYPE_DIM for searchbackpressureRCA to find the cell value for each stats type
* /
public static final String SEARCHBP_TYPE_DIM = "SearchBackPressureStats";
There was a problem hiding this comment.
Latest commit added comments for 2 constants separately. Resolved.
…DIM (signed-off-by: Jeffrey Liu [email protected]) Signed-off-by: CoderJeffrey <[email protected]>
…[email protected]) Signed-off-by: CoderJeffrey <[email protected]>
| @@ -943,7 +943,9 @@ public enum SearchBackPressureStatsValue implements MetricValue { | |||
| SearchBackPressureStatsValue.Constants.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_MODE), | |||
| SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS( | |||
| SearchBackPressureStatsValue.Constants | |||
| .SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS); | |||
| .SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS), | |||
| SEARCHBP_TABLE_NAME(SearchBackPressureStatsValue.Constants.SEARCHBP_TABLE_NAME), | |||
There was a problem hiding this comment.
Why are we replicating this information ?
There was a problem hiding this comment.
.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS); change to
.SEARCHBP_SEARCH_BACK_PRESSURE_STATS_SEARCH_TASK_STATS), because it is not the final constants in the list
SEARCHBP_TABLE_NAME(SearchBackPressureStatsValue.Constants.SEARCHBP_TABLE_NAME), use this for easier access and consistent coding style.
(Signed off-by: Jeffrey Liu [email protected])
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
To fix on issue opensearch-project/performance-analyzer-rca#424. The PR mainly adds constatns required forthe reader to consume SearchBackPressure Service metrics.
Describe alternatives you've considered
N/A
Additional context
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.